KAFKA-7804: Update docs for topic-command related KIP-377 #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omkreddy I've updated the docs. Would you please have a look at it? Did you have something else too in your mind for updating? |
mrsrinivas
reviewed
Jan 11, 2019
mrsrinivas
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
These changes LGTM, Thanks for the PR!!
@viktorsomogyi, does this PR needs to linked with any code changes PR ?
Yes, it is for KAFKA-7433, PR: #5683 @viktorsomogyi I'd suggest to link these jiras together. |
|
Yep, linked them together. This is a dependency of #5683. That one has to be merged first. |
3 tasks
viktorsomogyi
force-pushed
the
topiccommand-adminclient-doc
branch
from
b928851
to
a584d9b
Compare
viktorsomogyi
commented
Feb 4, 2019
| @@ -509,7 +509,7 @@ object TopicCommand extends Logging { | |||
| private val configOpt = parser.accepts("config", "A topic configuration override for the topic being created or altered." + | |||
| "The following is a list of valid configurations: " + nl + LogConfig.configNames.map("\t" + _).mkString(nl) + nl + | |||
| "See the Kafka documentation for full details on the topic configs." + | |||
| "Not supported with the --bootstrap-server option.") | |||
| "It is supported only in combination with --create if --bootstrap-server option is used.") | |||
There was a problem hiding this comment.
@omkreddy fixed the doc issue here. Please take a look.
|
retest this please |
omkreddy
approved these changes
Feb 4, 2019
omkreddy
pushed a commit
that referenced
this pull request
Feb 4, 2019
This PR adds a upgrade notes and changes examples to use the bootstrap-server. Author: Viktor Somogyi-Vass <viktorsomogyi@gmail.com> Reviewers: Srinivas <srinivas96alluri@gmail.com>, Manikumar Reddy <manikumar.reddy@gmail.com> Closes #6118 from viktorsomogyi/topiccommand-adminclient-doc (cherry picked from commit 776041d) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
This PR adds a upgrade notes and changes examples to use the bootstrap-server. Author: Viktor Somogyi-Vass <viktorsomogyi@gmail.com> Reviewers: Srinivas <srinivas96alluri@gmail.com>, Manikumar Reddy <manikumar.reddy@gmail.com> Closes apache#6118 from viktorsomogyi/topiccommand-adminclient-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a upgrade notes and changes examples to use the bootstrap-server.
Committer Checklist (excluded from commit message)