KAFKA-7859: Use automatic RPC generation in LeaveGroups #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbccdda
force-pushed
the
leave_group
branch
2 times, most recently
from
213c27c
to
5c02d47
Compare
|
Thanks for the PR. Could you please rebase on |
|
@dhruvilshah3 this depends on another diff that will be landed to trunk soon. Waiting for that one to merge first. |
|
@cmccabe @dhruvilshah3 Hey Colin and Dhruvil, do you mind taking a look of this change? |
abbccdda
force-pushed
the
leave_group
branch
2 times, most recently
from
030c566
to
d18533b
Compare
cmccabe
reviewed
Jan 29, 2019
| @@ -433,7 +434,7 @@ class RequestQuotaTest extends BaseRequestTest { | |||
| case ApiKeys.FIND_COORDINATOR => new FindCoordinatorResponse(response).throttleTimeMs | |||
| case ApiKeys.JOIN_GROUP => new JoinGroupResponse(response).throttleTimeMs | |||
| case ApiKeys.HEARTBEAT => new HeartbeatResponse(response).throttleTimeMs | |||
| case ApiKeys.LEAVE_GROUP => new LeaveGroupResponse(response).throttleTimeMs | |||
| case ApiKeys.LEAVE_GROUP => new LeaveGroupResponse(response, 2).throttleTimeMs | |||
There was a problem hiding this comment.
Does it make sense to use the latest version of LeaveGroupResponse here? Something like LeaveGroupResponseData.SCHEMAS.length - 1
There was a problem hiding this comment.
Sounds good to me!
|
Hi @abbccdda, looks good! I left one comment. LGTM after that. |
|
FYI, I fixed the test to use latest schema version for both |
|
@cmccabe Hey Colin, would you mind taking another look? |
|
LGTM. Thanks, @abbccdda ! |
|
@cmccabe Great thank you!! |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* AK/trunk: fix typo (apache#5150) MINOR: Reduce replica.fetch.backoff.ms in ReassignPartitionsClusterTest (apache#5887) KAFKA-7766: Fail fast PR builds (apache#6059) KAFKA-7798: Expose embedded clientIds (apache#6107) KAFKA-7641; Introduce "group.max.size" config to limit group sizes (apache#6163) KAFKA-7433; Introduce broker options in TopicCommand to use AdminClient (KIP-377) MINOR: Fix some field definitions for ListOffsetReponse (apache#6214) KAFKA-7873; Always seek to beginning in KafkaBasedLog (apache#6203) KAFKA-7719: Improve fairness in SocketServer processors (KIP-402) (apache#6022) MINOR: fix checkstyle suppressions for generated RPC code to work on Windows KAFKA-7859: Use automatic RPC generation in LeaveGroups (apache#6188) KAFKA-7652: Part II; Add single-point query for SessionStore and use for flushing / getter (apache#6161) KAFKA-3522: Add RocksDBTimestampedStore (apache#6149) KAFKA-3522: Replace RecordConverter with TimestampedBytesStore (apache#6204)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
3 tasks
hachikuji
pushed a commit
that referenced
this pull request
Jul 22, 2019
…onse (#7101) This is a bug fix PR to resolve errors introduced in #6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Jul 22, 2019
…onse (#7101) This is a bug fix PR to resolve errors introduced in #6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Jul 22, 2019
…onse (#7101) This is a bug fix PR to resolve errors introduced in #6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 22, 2019
…n throttling and error response (apache#7101) TICKET = KAFKA-8678 LI_DESCRIPTION = EXIT_CRITERIA = HASH [f94ec1c] ORIGINAL_DESCRIPTION = This is a bug fix PR to resolve errors introduced in apache#6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io> (cherry picked from commit f94ec1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr serves as a sub task of JIRA: https://issues.apache.org/jira/browse/KAFKA-7830 to eventually replace all the hand-coded request/response interfaces with Colin's new automated generation protocols. There are still some dependencies of this pr over #5972, so we shall wait until it lands to continue address some minor issues.
Committer Checklist (excluded from commit message)