KAFKA-7440 Add leader epoch to fetch and list-offset request #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
reviewed
Jan 25, 2019
| this.metadata.requestUpdate(); | ||
| } else if (error == Errors.UNKNOWN_LEADER_EPOCH) { | ||
| log.warn("Received unknown leader epoch error in fetch for partition {}", tp); | ||
| this.metadata.requestUpdate(); |
There was a problem hiding this comment.
I think the metadata update may not be needed. UNKNOWN_LEADER_EPOCH means the consumer's metadata has gotten ahead of the broker, so we can just retry. The only thing I am not sure is whether we need additional backoff logic before retrying.
| @@ -992,6 +997,12 @@ private PartitionRecords parseCompletedFetch(CompletedFetch completedFetch) { | |||
| } else if (error == Errors.TOPIC_AUTHORIZATION_FAILED) { | |||
| log.warn("Not authorized to read from topic {}.", tp.topic()); | |||
| throw new TopicAuthorizationException(Collections.singleton(tp.topic())); | |||
| } else if (error == Errors.FENCED_LEADER_EPOCH) { | |||
| log.warn("Received fenced leader epoch error in fetch for partition {}", tp); | |||
| this.metadata.requestUpdate(); | |||
There was a problem hiding this comment.
Should we invalidate the fenced epoch somehow?
hachikuji
reviewed
Feb 1, 2019
| @@ -992,6 +997,11 @@ private PartitionRecords parseCompletedFetch(CompletedFetch completedFetch) { | |||
| } else if (error == Errors.TOPIC_AUTHORIZATION_FAILED) { | |||
| log.warn("Not authorized to read from topic {}.", tp.topic()); | |||
| throw new TopicAuthorizationException(Collections.singleton(tp.topic())); | |||
| } else if (error == Errors.FENCED_LEADER_EPOCH) { | |||
There was a problem hiding this comment.
We could probably add this to the errors on line 979 above. This is a "normal" error case, so I think we logging at debug level should be sufficient.
| log.warn("Received fenced leader epoch error in fetch for partition {}", tp); | ||
| this.metadata.requestUpdate(); | ||
| } else if (error == Errors.UNKNOWN_LEADER_EPOCH) { | ||
| log.warn("Received unknown leader epoch error in fetch for partition {}", tp); |
|
retest this please |
|
The failures are known flaky tests. I will go ahead and merge. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…#6190) As part of KIP-320, we should add the expected leader epoch to Fetch and ListOffsets requests. This will allow us ultimately to detect log truncation. Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)