Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-8060: The Kafka protocol generator should allow null defaults #6387

Closed
wants to merge 2 commits into from
Closed

KAFKA-8060: The Kafka protocol generator should allow null defaults #6387

wants to merge 2 commits into from

Conversation

cmccabe
Copy link
Contributor

@cmccabe cmccabe commented Mar 7, 2019

No description provided.

@cmccabe cmccabe mentioned this pull request Mar 7, 2019
Closed
3 tasks
omkreddy
omkreddy approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@omkreddy omkreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmccabe Thanks for the PR. LGTM other than checkstyle issue.

@omkreddy omkreddy closed this in 027cbba Mar 8, 2019
@cmccabe cmccabe deleted the KAFKA-8060 branch May 20, 2019 18:54
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@cmccabe @pengxiaolong
KAFKA-8060: The Kafka protocol generator should allow null defaults
1882f31 
Author: Colin P. Mccabe <cmccabe@confluent.io>

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>

Closes apache#6387 from cmccabe/KAFKA-8060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkreddy omkreddy omkreddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmccabe @omkreddy