KAFKA-8323: Should close filter in RocksDBStoreTest as well #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged #6676 to trunk |
bbejeck
pushed a commit
that referenced
this pull request
May 4, 2019
Forgot to also close the filter in RocksDBStoreTest in time. Reviewers: Bill Bejeck <bbejeck@gmail.com>
|
cherry-picked to 2.2 |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Forgot to also close the filter in RocksDBStoreTest in time. Reviewers: Bill Bejeck <bbejeck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to also close the filter in RocksDBStoreTest in time. Thanks @bbejeck for merging (too!) quickly 😄
Committer Checklist (excluded from commit message)