KAFKA-8265 : Match client config override prefix to match with the KIP #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mageshn
changed the title
|
@rhauch found another minor discrepancy between code and the KIP. Can you please take a look when you get a chance. |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
May 21, 2019
* apache-github/trunk: MINOR: Set `replicaId` for OffsetsForLeaderEpoch from followers (apache#6775) MINOR: A few logging improvements in the broker (apache#6773) KAFKA-8052; Ensure fetch session epoch is updated before new request (apache#6582) KAFKA-8315: fix the JoinWindows retention deprecation doc (apache#6664) KAFKA-8265: Fix override config name to match KIP-458. (apache#6776) KAFKA-3143: Controller should transition offline replicas on startup MINOR: Work around OpenJDK 11 javadocs issue. (apache#6747) MINOR: Bump version to 2.4.0-SNAPSHOT (apache#6774)
rhauch
pushed a commit
that referenced
this pull request
May 22, 2019
Author: Magesh Nandakumar <magesh.n.kumar@gmail.com> Reviewer: Randall Hauch <rhauch@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Author: Magesh Nandakumar <magesh.n.kumar@gmail.com> Reviewer: Randall Hauch <rhauch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to use the correct prefix for the configurations that are being overridden match with the documentation in KIP-458.
Committer Checklist (excluded from commit message)