KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap. #8224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zshuo
changed the title
zshuo
changed the title
|
@edoardocomar Could you please help review this? Thanks! |
|
@mimaison FYI, this part of code change has been confirmed works on z/OS. |
|
ok to test |
|
Is there anything else I need to do before it gets merged? |
|
@zshuo No. I've taken a look at the change and it looks good. By commenting |
mimaison
requested changes
Apr 23, 2020
There was a problem hiding this comment.
There is a checkstyle violation:
[ant:checkstyle] [ERROR] /Users/mickael/github-ws/kafka/clients/src/main/java/org/apache/kafka/common/utils/OperatingSystem.java:36: 'static initialization rcurly' has incorrect indentation level 5, expected level should be 4. [Indentation]
Can you fix the identation of the curly bracket in OperatingSystem.java:36?
You should see this issue if you run the build locally:
gradle
./gradlew build
|
ok to test |
1 similar comment
|
ok to test |
|
retest this please |
4 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
mimaison
approved these changes
Apr 24, 2020
|
Test failure is unrelated, merging |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Apr 29, 2020
…t-for-generated-requests * apache-github/trunk: (366 commits) MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters. (apache#7982) MINOR: document how to escape json parameters to ducktape tests (apache#8546) KAFKA-9885; Evict last members of a group when the maximum allowed is reached (apache#8525) KAFKA-9866: Avoid election for topics where preferred leader is not in ISR (apache#8524) KAFKA-9839; Broker should accept control requests with newer broker epoch (apache#8509) KAKFA-9612: Add an option to kafka-configs.sh to add configs from a prop file (KIP-574) MINOR: Partition is under reassignment when adding and removing (apache#8364) MINOR: reduce allocations in log start and recovery checkpoints (apache#8467) MINOR: Remove unused foreign-key join class (apache#8547) HOTFIX: Fix broker bounce system tests (apache#8532) KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap. (apache#8224) KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol (apache#8326) MINOR: equals() should compare all fields for generated classes (apache#8539) KAFKA-9844; Fix race condition which allows more than maximum number of members(apache#8454) KAFKA-9823: Remember the sent generation for the coordinator request (apache#8445) KAFKA-9883: Add better error message when REST API forwards a request and leader is not known (apache#8536) KAFKA-9907: Switch default build to Scala 2.13 (apache#8537) MINOR: Some html fixes in Streams DSL documentation (apache#8503) MINOR: Enable fatal warnings with scala 2.13 (apache#8429) KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms to reduce overall test runtime (apache#8464) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-9704
Committer Checklist (excluded from commit message)