-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: clean up Streams assignment classes and tests #8406
MINOR: clean up Streams assignment classes and tests #8406
Conversation
77baa5d
to
aee4dd6
Compare
test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
|
||
/** | ||
* Builds a UUID by repeating the given number n. For valid n, it is guaranteed that the returned UUIDs satisfy | ||
* the same relation relative to others as their parameter n does: iff n < m, then uuidForInt(n) < uuidForInt(m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just important to produce stable test results for verification?
Failed due to github outage. Retest this, please |
Hey @ableegoldman , looks like there are some problems:
|
can now remove the StreamsPartitionassignor checkstyle suppression!
f39fdd9
to
2aefb7b
Compare
test this please |
1 similar comment
test this please |
First set of cleanup pushed to followup PR after KIP-441 Pt. 5. Main changes are:
RankedClient
and the staticbuildClientRankingsByTask
to a new fileMovement
and the staticgetMovements
to a new file (also renamed toTaskMovement
)AssignmentTestUtils
TaskAssignor
and all related classesKeep in mind, this does not represent the sum whole of all cleanup we'd like to do. But if there's anything you had in mind that you feel would fit in with the other changes in this PR, feel free to point it out