-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API #8947
Conversation
…orised to use ListPartitionReassignments API
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dajac Thanks for the PR. LGTM. Will merge after tests status.
looks like PR has conflicts with 2.5 branch. Can you please raise separate PR for 2.5 branch?
retest this please |
@dajac We have ambiguous reference error for scala 2.12
|
@omkreddy I just pushed a fix. |
retest this please |
ok to test |
…orised to use ListPartitionReassignments API Since https://issues.apache.org/jira/browse/KAFKA-8834, describing topics with the TopicCommand requires privileges to use ListPartitionReassignments or fails to describe the topics with the following error: > Error while executing topic command : Cluster authorization failed. This is a quite hard restriction has most of the secure clusters do not authorize non admin members to access ListPartitionReassignments. This patch catches the `ClusterAuthorizationException` exception and gracefully fails back. We already do this when the API is not available so it remains consistent. Author: David Jacot <djacot@confluent.io> Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> Closes #8947 from dajac/KAFKA-10212 (cherry picked from commit 4be4420) Signed-off-by: Manikumar Reddy <mkumar@xtreems.local>
Since https://issues.apache.org/jira/browse/KAFKA-8834, describing topics with the TopicCommand requires privileges to use ListPartitionReassignments or fails to describe the topics with the following error:
This is a quite hard restriction has most of the secure clusters do not authorize non admin members to access ListPartitionReassignments.
This patch catches the
ClusterAuthorizationException
exception and gracefully fails back. We already do this when the API is not available so it remains consistent.Committer Checklist (excluded from commit message)