KAFKA-10316: Updated Kafka Streams upgrade notes. #9133
Conversation
* Deprecated the existing getters and added new getters `activeHost()`, `standbyHosts()`, and `partition()` to KeyQueryMetadata.java.
* Update the existing Tests to use the new getters of KeyQueryMetadata.java . Below are the Test classes that were updated with new getters.
OptimizedKTableIntegrationTest.java
QueryableStateIntegrationTest.java
StoreQueryIntegrationTest.java
StreamsMetadataStateTest.java
* Deprecated the existing getters and added new getters `activeHost()`, `standbyHosts()`, and `partition()` to KeyQueryMetadata.java.
* Update the existing Tests to use the new getters of KeyQueryMetadata.java . Below are the Test classes that were updated with new getters.
OptimizedKTableIntegrationTest.java
QueryableStateIntegrationTest.java
StoreQueryIntegrationTest.java
StreamsMetadataStateTest.java
* Correcting some JavaDoc nits.
Merge apache/kafka to johnthotekat/kafka
…tps://github.com/johnthotekat/kafka into KAFKA-10316-renaming-getter-method
Adding KIP-648 documentations to streams upgrade notes.
|
@mjsax I've checked the actual documentations and just to make sure I've also checked for the occurrence of the deprecated methods throughout the repo and found none (except in the classes and upgrade-guide which we modified). |
| @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final Set<HostInfo> standbyHo | |||
| } | |||
|
|
|||
| /** | |||
| * Get the Active streams instance for given key | |||
There was a problem hiding this comment.
As the original PR is merged already, this seems to be redundant (similar below for all other code changes). -- This PR should only update the html file?
There was a problem hiding this comment.
Yeah , this should only update the html file. I raised the PR from the same branch. Err., I wonder, as these changes were already merged, should it even be showing these as changes here ? I'm saying about the previous changes which were already merged.
There was a problem hiding this comment.
If you see from the commit history in the timeline . My last commit is : 14ab052 (this has only the html changes) and all the ones before that are already merged to trunk. Am I missing something here for the previous changes to show up in this PR too?
There was a problem hiding this comment.
Not sure. I am not an git guru... Can you maybe just rebase this PR against latest trunk (just to make sure we don't mess anything up?)
|
Closing this PR. Raised another PR #9146 . |
docs/streams/upgrade-guide.html.@mjsax