KAFKA-10454 / (2.6) Update copartitionSourceGroups when optimization algorithm is triggered #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thm is triggered (apache#9237) Fix KAFKA-10454 bug Main issue was that when optimization algorithm was removing repartition nodes, corresponding copartitionSourceGroups was never updated. As a result, copartition enforcer wasn't able to do the checks and set proper number of partitions. Test ensures that whenever optimization is set, changelog topic for the table is not created. And whenever optimization is turned off, appropriate changelog topic for the table is created. Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
3 tasks
|
ok to test |
|
Hi @mimaison , do you think we can get this into 2.6.1? |
|
@bbejeck Yes we can include this into 2.6 |
|
@bbejeck What's the status of this PR? can we get it merged this week? |
@mimaison yes, I've been waiting on the Jenkins build which I believe is fixed now. Once I can get the build ran, I'll merge it. |
|
ok to test |
|
Test this please |
bbejeck
approved these changes
Nov 2, 2020
|
Ran the tests locally and everything passed |
|
merged #9468 into 2.6 |
|
\cc @mimaison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picking #9237 on 2.6 branch
Committer Checklist (excluded from commit message)