KAFKA-10854: Fix flaky testConnectionRatePerIp test #9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 15, 2020
…keys * apache-github/trunk: KAFKA-10776: Add version attribute in RequestsPerSec metrics documentation (apache#9661) KAFKA-10854: fix flaky testConnectionRatePerIp test (apache#9752) KAFKA-10525: Emit JSONs with new auto-generated schema (KIP-673) (apache#9526)
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flaky test is because we expected our last(6th) connection will be the one connection who got throttled, but this is not true. The reason is:
(1)
selector.select()will return the channels that are ready, so the last connection might not get ready in the last(2) the
selector.selectedKeys()returnsSet<SelectionKey>, and the data structureSetdoesn't provide any ordering guaranteesSo, to fix it, in the setup phase, I created (maximum allowable number + 1) of connections, and make sure there's 1 connection throttled. And then, we can make sure the next connection will also get throttled( of course the time is not ticking due to we use
MockTime), so that we can make the tests more reliable.Committer Checklist (excluded from commit message)