MINOR: Generalize server startup to make way for KIP-500 #9883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
reviewed
Jan 14, 2021
cmccabe
reviewed
Jan 14, 2021
cmccabe
reviewed
Jan 15, 2021
cmccabe
reviewed
Jan 15, 2021
| val roles = getList(KafkaConfig.ProcessRolesProp).asScala.map { | ||
| case "broker" => BrokerRole | ||
| case "controller" => ControllerRole | ||
| case role => throw new ConfigException(s"Unknown process role $role") |
There was a problem hiding this comment.
can you list the valid roles in this exception?
|
LGTM. I had one small comment. Thanks, @hachikuji |
hachikuji
force-pushed
the
generalize-kafka-server
branch
from
45da7db
to
ad34155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to generalize server initialization for KIP-500. It adds a
Servertrait whichKafkaServerextends for the legacy Zookeeper server, and a newKafkaRaftServerfor the new server. I have also added stubs forKafkaRaftBrokerandKafkaRaftControllerto give a clearer idea how this will be used.This patch attempts to be non-intrusive, but it's worth pointing out that it does away with
KafkaServerStartable. I believe this was intended to support custom startup logic, but it is not an official API and we do not plan to support it after KIP-500.Committer Checklist (excluded from commit message)