Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-9126: Add docs for stream joined logging configs #9951

Merged
merged 1 commit into from
Jan 26, 2021
Merged

KAFKA-9126: Add docs for stream joined logging configs #9951

merged 1 commit into from
Jan 26, 2021

Conversation

lct45
Copy link
Contributor

@lct45 lct45 commented Jan 22, 2021

Adding docs for KIP-689 / KAFKA-9126 which added withLoggingEnabled() and withLoggingDisabled() to StreamJoined

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@lct45
Copy link
Contributor Author

lct45 commented Jan 22, 2021 •
edited
Loading

@mjsax @wcarlson5 @JimGalasyn for review

JimGalasyn
JimGalasyn approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjsax mjsax merged commit 6c8033a into apache:trunk Jan 26, 2021
@mjsax mjsax added docs kip Requires or implements a KIP streams labels Jan 26, 2021
@mjsax mjsax mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
docs kip Requires or implements a KIP streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lct45 @JimGalasyn @mjsax