Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylint to pre-commit #90

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Commits on Oct 12, 2020

  1. Refactor setup.py (apache#48)

    This PR introduces some structure to setup.py by encapsulating
    some parts of the logic into functions and creating the main
    function.
    turbaszek committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    a2d61ac View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Introduce github actions for CI (apache#47)

    * Introduce github actions for CI
    
    * fixup! Introduce github actions for CI
    turbaszek committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    b371d80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2002a53 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. Configuration menu
    Copy the full SHA
    9376200 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Configuration menu
    Copy the full SHA
    aaae65d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Configuration menu
    Copy the full SHA
    7092e86 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Configuration menu
    Copy the full SHA
    5e18332 View commit details
    Browse the repository at this point in the history
  2. Make Kibble a package (apache#67)

    This commit refactors the code base to create an installable
    kibble application.
    
    Co-authored-by: Michał Słowikowski <michalslowikowski00@gmail.com>
    turbaszek and michalslowikowski00 committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    edb9a91 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    340f104 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e4563ca View commit details
    Browse the repository at this point in the history
  5. Add Black to pre-commit (apache#66)

    Add Black to pre-commit and format whole codebase
    Michał Słowikowski committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    d7f9031 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Configuration menu
    Copy the full SHA
    17e6734 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2abfcc8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d5f537 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5471c07 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Use KibbleConfigParser in setup script (apache#83)

    * Use KibbleConfigParser in setup script
    
    * fixup! Use KibbleConfigParser in setup script
    turbaszek committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    6959f3c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Configuration menu
    Copy the full SHA
    0a11b51 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    4884cf5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. Configuration menu
    Copy the full SHA
    7d70dd5 View commit details
    Browse the repository at this point in the history
  2. Build docker image on CI (apache#92)

    To check that kibble works we can at least build the docker image,
    run kibble --help and validate python requirements.
    turbaszek committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    3d03a24 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Configuration menu
    Copy the full SHA
    639f10c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Remove unused variables (apache#98)

    * removed few unused variables from code
    
    * bugzilla – removed unused variables from code
    
    * git-census – removed unused variable
    
    * buildbot – removed unused variable
    
    * pipermail – removed unused variable
    
    * ponymail – removed unused variable
    
    * discourse – removed unused variable
    
    * github-issues – removed unused variable
    
    * jenkins – removed unused variable
    
    * jira – removed unused variable
    
    * github-stats – removed unused variable
    
    * ponymail – removed unused variable
    
    * git-evolution – removed unused variable
    Michał Słowikowski committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    1aa6804 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    393635e View commit details
    Browse the repository at this point in the history
  3. fix doc typo (apache#99)

    Michał Słowikowski committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    5228a4a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. Fix broken Kibble (apache#106)

    Before this commit I got this error when running Kibble locally:
    This was because https://github.com/apache/kibble/pull/83 replaced kibble.yaml with kibble.ini
    This PR reads the config from `kibble.ini`.
    This also adds a network to docker-compose file without which I was getting host not found error.
    kaxil committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    e437790 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. Configuration menu
    Copy the full SHA
    275c55f View commit details
    Browse the repository at this point in the history
  2. Fix asf.yaml INFRA link (apache#102)

    Replace old link with new link
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    36e2cf7 View commit details
    Browse the repository at this point in the history
  3. Replace mention of 'master' branch with 'main' (apache#103)

    `master` branch was renamed with `main`. This should reflect in doc.
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    d285764 View commit details
    Browse the repository at this point in the history
  4. Use https URL for Kibble in setup.py (apache#104)

    Since https://kibble.apache.org/ is available we should use that instead of http
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    e07e601 View commit details
    Browse the repository at this point in the history
  5. Fix various typos (apache#105)

    `Kible` -> `Kibble`
    `milis` -> `milliseconds`
    `offlined` -> `offline`
    `annalyze` -> `analyze`
    `Verrifying` -> `Verifying`
    `betwen` -> `between`
    `fechthing` -> `fetching`
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    076bbe4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f03b7ed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1876559 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d9a3893 View commit details
    Browse the repository at this point in the history
  9. Upgrade black to 20.8b1 (apache#112)

    Upgrade black pre-commit from `19.3b0` to `20.8b1`
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    729256f View commit details
    Browse the repository at this point in the history
  10. Improve Code Quality (apache#113)

    - Comparison with None
    - Redundant Parenthesis
    - Remove unused variable
    - Fix mutable default arguments
    - Augmented assignment expressions
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    3485535 View commit details
    Browse the repository at this point in the history
  11. Fix unresolved reference error in kibble/api/plugins/database.py (apa…

    …che#111)
    
    There was no such variable `ESVersion` -- possibly a typo as `self.ESversion` is defined on line 147
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    c14a053 View commit details
    Browse the repository at this point in the history
  12. Install cloc in Dockerfile to fix git scanner (apache#110)

    Install cloc (https://github.com/AlDanial/cloc). `cloc` is a Prerequisite as mentioned in https://apache-kibble.readthedocs.io/en/latest/setup.html#installing-the-server
    Without it the count in the git scanner fails.
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    5bf37a8 View commit details
    Browse the repository at this point in the history
  13. Fix failing test & Run tests on CI (apache#115)

    This PR adds Github Action job to run tests on CI & fix a failing test
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    89748e4 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    ea59ae0 View commit details
    Browse the repository at this point in the history
  15. Add scan command to run scanners (apache#114)

    Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
    turbaszek and kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    f3a4b27 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b4025c2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f042a59 View commit details
    Browse the repository at this point in the history
  18. Fix the path for the scanners in scanners/README.md (apache#119)

    The paths were incorrect, I think they are from before when they were in a separate repo
    kaxil committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    257992d View commit details
    Browse the repository at this point in the history
  19. Improve code quality of scanners (apache#120)

    This PR replaces cameleCase with snake_case, removes some unused
    variables and adds some that in some cases may result in run time error.
    turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    f8d731c View commit details
    Browse the repository at this point in the history
  20. Make scanners use kibble.ini instead of config.yaml (apache#122)

    This PR moved watson, azure, picoapi and git configuration to
    kibble.ini config file. It fixes also reading ES configuration.
    In this way all Kibble configuration is in single place.
    turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    e19cf6c View commit details
    Browse the repository at this point in the history
  21. Add pylint to pre-commit

    pylint wip
    
    wip, pylint
    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    344832b View commit details
    Browse the repository at this point in the history
  22. add pylintrc file

    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    aca8b1d View commit details
    Browse the repository at this point in the history
  23. added suggestion from review

    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    fc72297 View commit details
    Browse the repository at this point in the history
  24. Add pylint to pre-commit

    pylint wip
    
    wip, pylint
    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    99f81fe View commit details
    Browse the repository at this point in the history
  25. add pylintrc file

    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    e874d8b View commit details
    Browse the repository at this point in the history
  26. Update pylintrc

    turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    0b7ce3a View commit details
    Browse the repository at this point in the history
  27. fixup! rebase on latest master

    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    232f7be View commit details
    Browse the repository at this point in the history
  28. fixed unused-import

    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    39a5e71 View commit details
    Browse the repository at this point in the history
  29. added missing-module-docstring

    michalslowikowski00 authored and turbaszek committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    29d29c7 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    2a65d75 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Run pylint locally

    turbaszek committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    5b612c8 View commit details
    Browse the repository at this point in the history