Fix the migrating slot didn't compatible with old format #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseto
commented
May 10, 2025
store/cluster_shard.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| NotMigratingString = "not-migrating" |
There was a problem hiding this comment.
Up to suggestions on what string we want here...
bseto
changed the title
|
@bseto Thanks for your efforts. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #310 +/- ##
============================================
+ Coverage 43.38% 46.76% +3.37%
============================================
Files 37 45 +8
Lines 2971 4386 +1415
============================================
+ Hits 1289 2051 +762
- Misses 1544 2128 +584
- Partials 138 207 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
git-hulk
reviewed
May 12, 2025
cmd/client/command/helper.go
Outdated
| if shard.MigratingSlot != nil { | ||
| migratingStatus = fmt.Sprintf("%s --> %d", shard.MigratingSlot, shard.TargetShardIndex) | ||
| if shard.MigratingSlot.IsMigrating { | ||
| migratingStatus = fmt.Sprintf("%s --> %d", &shard.MigratingSlot.SlotRange, shard.TargetShardIndex) |
store/cluster_shard.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| NotMigratingString = "not-migrating" |
There was a problem hiding this comment.
We could keep the field null if it's not migrating.
git-hulk
approved these changes
May 13, 2025
git-hulk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@git-hulk I based the PR on your previous PR.
For some additional context: #308 (comment)
Did some manual testing
-1migrating_slotvalueunstablebranch with thenullvalue. (so any clusters created from May 3rd to now will not be compatible)