Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4499 Refine waiting time for initialization #1268

Closed
wants to merge 1 commit into from

Conversation

kyotoYaho
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

coveralls commented Jun 17, 2020

Pull Request Test Coverage Report for Build 6031

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 27.98%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 6029: 0.01%
Covered Lines: 26113
Relevant Lines: 93326

💛 - Coveralls

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2020

This pull request introduces 1 alert when merging 5ade33a into d05a23f - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

zzcclp added a commit to zzcclp/kylin that referenced this pull request Jun 17, 2020
@hit-lacus
Copy link
Member

Close this because it is merged in #1271

@hit-lacus hit-lacus closed this Jun 17, 2020
zzcclp added a commit to zzcclp/kylin that referenced this pull request Jun 17, 2020
hit-lacus pushed a commit that referenced this pull request Jun 18, 2020
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
hit-lacus pushed a commit that referenced this pull request Jun 27, 2021
yanghong's PR #1268

(cherry picked from commit 121f8d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants