Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for EMC Atmos and thus Ninefold Storage #19

Closed
wants to merge 39 commits into from

Conversation

jeamland
Copy link

@jeamland jeamland commented Jul 3, 2011

These commits add support for the EMC Atmos storage API and add Ninefold as a storage provider.

xhdrs = [(k, v) for k, v in headers.items() if k.startswith('x-emc-')]
xhdrs.sort(key=lambda x: x[0])

signature = [
Copy link
Member

@Kami Kami Jul 3, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably a good idea to refactor signature part into a separate method. It will also make testing easier.

Copy link
Author

@jeamland jeamland Jul 4, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signature method split out in 6d68c6b, tests for signature method added in 488965b.

if pathstring.startswith(self.driver.path):
pathstring = pathstring[len(self.driver.path):]
if params:
if type(params) is dict:
Copy link
Member

@Kami Kami Jul 7, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't really like this check...

Maybe we should just thrown a TypeError if users passes in anything other than dict as the params argument.

Copy link
Author

@jeamland jeamland Jul 16, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urllib allows either a dict or an iterable of 2-tuples. The check is to force it to the latter so that the order remains the same. I'm happy to code in an assumption that it's dict but it depends on whether you want to impose that constraint.

@Kami
Copy link
Member

Kami commented Jul 15, 2011

Any updates? It would be nice to merge it.

@jeamland
Copy link
Author

jeamland commented Jul 16, 2011

Sorry about the delay. Our second child arrived on Monday and strangely I haven't had much time to hack on things. =)

@Kami
Copy link
Member

Kami commented Jul 17, 2011

No problem and congratulations!

I will try to merge this branch over the weekend :)

raise StopIteration

yield chunk
if fill_size:
if empty or len(data) >= chunk_size:
Copy link
Member

@Kami Kami Jul 17, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equality comparison here doesn't really make sense because it's the same as the else case.

Copy link
Author

@jeamland jeamland Jul 20, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The else case is against if fill_size though. Basically that test doesn't bother sending a chunk unless it's the right size or unless we've run out of new data.

Copy link
Member

@Kami Kami Jul 20, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, oops, I missed that.

@Kami
Copy link
Member

Kami commented Jul 21, 2011

Looks OK. Can you please create a ticket on jira and submit a patch there and I'll try to merge it today?

Thanks!

@Kami
Copy link
Member

Kami commented Oct 26, 2013

(just doing some pull request cleanup)

@jeamland - Those changes have been merged a long time ago, can you please close this pull request?

Thanks!

@asfgit asfgit closed this in 5591e2e Jan 17, 2015
Kami pushed a commit to Kami/libcloud that referenced this issue Oct 28, 2021
* Self cancellation

* Missing check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants