Cloudstack Driver - Create/Delete Network functionality + tests #316
Conversation
|
/cc @Runseb |
| Class representing a CloudStack Network Offering. | ||
| """ | ||
|
|
||
| def __init__(self, name, displaytext, guestiptype, id, serviceofferingid, |
There was a problem hiding this comment.
For consistency with existing code and other drivers, please use _ to separate words in the argument names - display_text, guest_ip_type, service_offerring_id, for_vpc, etc.
|
Thx for the quick feedback, see 50e6c75 with the suggested changes for consistancy reasons. |
| return networkofferings | ||
|
|
||
| def ex_create_network(self, displaytext, name, networkoffering, | ||
| location, **kwargs): |
There was a problem hiding this comment.
You still need to fix the kwargs issue. We prefer to explicitly list the arguments that you need: gateway, net mask, vpc_id
add optinal args for ex_create_network extend network dictionary fix tests accordingly
|
Can you squash your commits ? that would make a clean PR. thx |
|
I've squashed the commits, renamed some variables to use underscores and merged patch into trunk. Thanks. |
|
Thx just squashed before noticing you already did. Thx! Kind Regards, Sent from a mobile device.
|
|
@Kami you were not that nice with me when I submitted pr :) …maybe once |
|
@Runseb heh, I can't always easily squash the commits - if the branch is not in sync with trunk, trying to apply the patch results in conflicts and resolving this is quite painful (although, I do it every now and then). |
Functions added on the cloudstack driver:
ex_list_network_offering
ex_create_network
ex_delete_network
New Object:
CloudStackNetworkOffering
And some additions to the CloudStackNetwork dictionary
netmask
gatway
vpcid