Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudstack Driver - Create/Delete Network functionality + tests #316

Closed
wants to merge 10 commits into from

Conversation

boul
Copy link

@boul boul commented Jun 11, 2014

Functions added on the cloudstack driver:

ex_list_network_offering
ex_create_network
ex_delete_network

New Object:
CloudStackNetworkOffering

And some additions to the CloudStackNetwork dictionary
netmask
gatway
vpcid

@Kami
Copy link
Member

Kami commented Jun 11, 2014

/cc @Runseb

Class representing a CloudStack Network Offering.
"""

def __init__(self, name, displaytext, guestiptype, id, serviceofferingid,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with existing code and other drivers, please use _ to separate words in the argument names - display_text, guest_ip_type, service_offerring_id, for_vpc, etc.

@boul
Copy link
Author

boul commented Jun 11, 2014

Thx for the quick feedback, see 50e6c75 with the suggested changes for consistancy reasons.

return networkofferings

def ex_create_network(self, displaytext, name, networkoffering,
location, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to fix the kwargs issue. We prefer to explicitly list the arguments that you need: gateway, net mask, vpc_id

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it. Cheers!

Roeland Kuipers added 3 commits June 12, 2014 11:46
add optinal args for ex_create_network
extend network dictionary
fix tests accordingly
@sebgoa
Copy link
Member

sebgoa commented Jun 12, 2014

Can you squash your commits ? that would make a clean PR. thx

@asfgit asfgit closed this in 33ca3b2 Jun 12, 2014
@Kami
Copy link
Member

Kami commented Jun 12, 2014

I've squashed the commits, renamed some variables to use underscores and merged patch into trunk. Thanks.

@boul
Copy link
Author

boul commented Jun 12, 2014

Thx just squashed before noticing you already did. Thx!

Kind Regards,
Roeland Kuipers

http://www.schubergphilis.com

Sent from a mobile device.

Op 12 jun. 2014 om 20:51 heeft Tomaz Muraus notifications@github.com het volgende geschreven:

I've squashed the commits, renamed some variables to use underscores and merged patch into trunk. Thanks.


Reply to this email directly or view it on GitHub.

@sebgoa
Copy link
Member

sebgoa commented Jun 12, 2014

@Kami you were not that nice with me when I submitted pr :) …maybe once

@Kami
Copy link
Member

Kami commented Jun 12, 2014

@Runseb heh, I can't always easily squash the commits - if the branch is not in sync with trunk, trying to apply the patch results in conflicts and resolving this is quite painful (although, I do it every now and then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants