Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds dns support for BuddyDNS #742

Closed
wants to merge 4 commits into from
Closed

adds dns support for BuddyDNS #742

wants to merge 4 commits into from

Conversation

jetbird
Copy link
Contributor

@jetbird jetbird commented Apr 10, 2016

No description provided.

@jetbird
Copy link
Contributor Author

jetbird commented Apr 10, 2016

@tonybaloney check it man :)

@@ -0,0 +1,135 @@
import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely need the Apache license header in this file

@tonybaloney
Copy link
Contributor

@jetbird another great contribution! just a couple of small changes, you need to add the Apache license header to the 2 files I noted.

@jetbird
Copy link
Contributor Author

jetbird commented Apr 10, 2016

@tonybaloney thanks man! Done :)

@Kami
Copy link
Member

Kami commented Apr 10, 2016

@jetbird Since this is a bigger change please make sure to submit an ICLA (http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) and select to notify the Libcloud project :)

:type extra: ``dict``

:rtype: :class:`Zone`
Do not forget to pass the master in extra,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume master key is only required for slave zones? or?

If so, you could probably throw if type is slave and 'master' not in extra or similar...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs the key master is always required when doing a POST request for creating a new zone.
https://www.buddyns.com/support/api/v2/

@Kami
Copy link
Member

Kami commented Apr 10, 2016

Is this pull request sill work in progress or considered complete?

I'm wondering because I only see methods for zone (domain) management, but no methods for managing records.

@Kami
Copy link
Member

Kami commented Apr 10, 2016

As Anthony has said, nice work so far 👍

@jetbird
Copy link
Contributor Author

jetbird commented Apr 10, 2016

@Kami the provider does not support operation on records.

@Kami
Copy link
Member

Kami commented Apr 11, 2016

ACK the receival of ICLA. Thanks.

@tonybaloney
Copy link
Contributor

@jetbird one more thing, I tagged you in a commit since I missed it on the other 2 PRs.
You need to update libcloud/dns/providers.py

@asfgit asfgit closed this in 7b0fc64 Apr 12, 2016
asfgit pushed a commit that referenced this pull request Apr 12, 2016
@Kami
Copy link
Member

Kami commented Apr 13, 2016

@jetbird I also noticed you don't have your git name and email fully configured.

Please follow the instructions at https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup and configure your git name and email. This way it's easier for us to track commits back to actual contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants