-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds dns support for BuddyDNS #742
Conversation
@tonybaloney check it man :) |
@@ -0,0 +1,135 @@ | |||
import sys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You definitely need the Apache license header in this file
@jetbird another great contribution! just a couple of small changes, you need to add the Apache license header to the 2 files I noted. |
@tonybaloney thanks man! Done :) |
@jetbird Since this is a bigger change please make sure to submit an ICLA (http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) and select to notify the Libcloud project :) |
:type extra: ``dict`` | ||
|
||
:rtype: :class:`Zone` | ||
Do not forget to pass the master in extra, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume master
key is only required for slave zones? or?
If so, you could probably throw if type is slave and 'master' not in extra or similar...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs the key master is always required when doing a POST request for creating a new zone.
https://www.buddyns.com/support/api/v2/
Is this pull request sill work in progress or considered complete? I'm wondering because I only see methods for zone (domain) management, but no methods for managing records. |
As Anthony has said, nice work so far 👍 |
@Kami the provider does not support operation on records. |
ACK the receival of ICLA. Thanks. |
@jetbird one more thing, I tagged you in a commit since I missed it on the other 2 PRs. |
@jetbird I also noticed you don't have your git name and email fully configured. Please follow the instructions at https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup and configure your git name and email. This way it's easier for us to track commits back to actual contributors. |
No description provided.