Condition internal debug logging on its enabled state

[swebb2066]

No description provided.

[rm5248]

This seems a bit cleaner:

Suggested change

	if (!LogLog::isDebugEnabled())
	;
	else if (appender != 0)
	if (LogLog::isDebugEnabled() && appender != nullptr)

[swebb2066]

The empty if avoids extra indentation and guards the else case which is also a LogLog::debug statement

[rm5248]

Since we have a lot of internal log messages that only log strings, would it make sense to make a vararg or parameter packed version of LogLog::debug()? That way you could do something like LogLog::debug("Opening file ", filename, " failed"); which would automatically concatenate the strings. That would also make the LOGLOG_DEBUG macro more useful.

[swebb2066]

would it make sense to make a vararg or parameter packed version of LogLog::debug()?

I do not know how to use parameter packs and achieve avoiding message building when debug is disabled. I believe internal debug logging is currently sparse (limited to infrequently executed code) to reduce overhead. The LogLog::isDebugEnabled() is much higher overhead than Logger::isDebugEnabledFor(logger)