Allow for use of either Qt5 or Qt6 #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Qt
#defines emit
, theLogLog
class fails to compile properly as the function prototype no longer exists.Oddly this works fine in Qt5, but it breaks with Qt6. We can work around it with defining
QT_NO_KEYWORDS
, but this would require anybody who links with us and with Qt to define this as well, which is not a good requirement for a library.