Skip to content

Conversation

rm5248
Copy link
Contributor

@rm5248 rm5248 commented Mar 16, 2025

Since Qt #defines emit, the LogLog class fails to compile properly as the function prototype no longer exists.

Oddly this works fine in Qt5, but it breaks with Qt6. We can work around it with defining QT_NO_KEYWORDS, but this would require anybody who links with us and with Qt to define this as well, which is not a good requirement for a library.

@rm5248
Copy link
Contributor Author

rm5248 commented Mar 16, 2025

Note: if removing the emit function prototype breaks the ABI(I don't think it should since it's private static and is only inside of the LogLog class), we can always wrap it in a preprocessor macro that is only defined when building the library itself.

@rm5248 rm5248 merged commit a26accd into master Mar 17, 2025
32 checks passed
@rm5248 rm5248 deleted the qt6-support branch March 17, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant