(doc) Fix environment variable for formatMsgNoLookups #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the heads up @fxshlein! Please note that this correction is against |
|
I was going off this: https://logging.apache.org/log4j/2.x/manual/configuration.html Although its completely removed there now. This morning it was still there 😉 |
Kylepoops
added a commit
to Kylepoops/HMCL
that referenced
this pull request
Dec 11, 2021
This was referenced Dec 11, 2021
huanghongxun
pushed a commit
to HMCL-dev/HMCL
that referenced
this pull request
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation currently says
FORMAT_MESSAGES_PATTERN_DISABLE_LOOKUPSis the correct environment variable to disable the message pattern lookups, however after testing, it seems thatLOG4J_FORMAT_MSG_NO_LOOKUPSis actually correct. (It also fits in with the other environment variables)Even though this option is deprecated in the newest version, this could make people wrongfully think
FORMAT_MESSAGES_PATTERN_DISABLE_LOOKUPSworks on older deployments where the log4j version is not able to be updated.