[LOG4J2-1855] Add an optional random delay in TimeBasedTriggeringPolicy #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
reviewed
Apr 2, 2017
| * @return a TimeBasedTriggeringPolicy. | ||
| */ | ||
| @PluginFactory | ||
| public static TimeBasedTriggeringPolicy createPolicy( | ||
| @PluginAttribute("interval") final String interval, | ||
| @PluginAttribute("modulate") final String modulate) { | ||
| @PluginAttribute("modulate") final String modulate, | ||
| @PluginAttribute("maxRandomDelay") final int maxRandomDelay) { |
There was a problem hiding this comment.
Instead of adding a new param to the factory method, do you think you could convert this to a builder and deprecate this method? This way, users who have used the factory method programmatically will not have an API change break their config, and this way we can also use the type conversion support to simplify the builder/factory as it is.
There was a problem hiding this comment.
OK I will do that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/LOG4J2-1855