SOLR-14940: Add ability to remove SolrCore.closeHooks. Keep reference… #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown()
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
Outdated
Show resolved
Hide resolved
…it and moved removeCloseHooks in ReplicationHandler.shutdown to run after execution of close hooks
anverus
commented
Oct 16, 2020
Comment on lines
+1415
to
+1418
| startShutdownHook.preClose(core); | ||
| startShutdownHook.postClose(core); | ||
| finishShutdownHook.preClose(core); | ||
| finishShutdownHook.postClose(core); |
There was a problem hiding this comment.
Order of these calls copies order of execution of instructions in original shutdown method, while the correct order seems to be
startShutdownHook.preClose(core);
finishShutdownHook.preClose(core);
startShutdownHook.postClose(core);
finishShutdownHook.postClose(core);
madrob
pushed a commit
that referenced
this pull request
Oct 27, 2020
…Hooks * Added ability to remove SolrCore.closeHooks * Keep references to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown() closes #1997
msfroh
pushed a commit
to msfroh/lucene-solr
that referenced
this pull request
Nov 18, 2020
…Hooks * Added ability to remove SolrCore.closeHooks * Keep references to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown() closes apache#1997
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
…Hooks * Added ability to remove SolrCore.closeHooks * Keep references to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown() closes apache#1997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown()
Description
Please provide a short description of the changes you're making with this pull request.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
masterbranch../gradlew check.