[10.3] Fix returned Impacts when frequencies are not indexed #15263
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
reviewed
Sep 30, 2025
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java
Outdated
Show resolved
Hide resolved
|
Added a single test here and open #15266 for a bigger coverage in the active branches. |
|
If not already the case, let’s forward port the test to main. |
|
@ChrisHegarty see #15266 |
jpountz
reviewed
Oct 1, 2025
| (No changes) | ||
| * GITHUB#15263: Fix the returned Impact returned from Lucene103PostingsReader when frequencies | ||
| are not indexed. It was returning a wrong frequency in that case affecting scoring which | ||
| might led to performance issues. (Ignacio Vera) |
There was a problem hiding this comment.
nit: maybe replace "wrong" with "suboptimal" since it's correct to return impact scores that are much higher than they should, just suboptimal as it hurts dynamic pruning?
|
For the record, this looks good to me! |
|
Wasn't this already fixed in #14511 ? |
|
yes @msfroh apparently in all the shuffle with the new postings, it was accidentally overwritten and then fixed again in main, but never backported. Quite the kerfuffle :D |
|
Ahh -- looks like #14557 backported the 101 postings reader to 10_x, but missed the 103 postings reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an Impact object with freqs equal to 1 instead of Integer.MAX_VALUE.
Note that this bug does not exists in main as it was fixed in #15151
Iam working on adding a test