Add test to check return values of frequency and norm when there are no frequencies #15266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
tteofili
approved these changes
Oct 1, 2025
jpountz
reviewed
Oct 1, 2025
|
|
||
| protected boolean indexFakeImpacts() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
should we remove this and fix all postings formats that don't pass the test?
There was a problem hiding this comment.
That sounds a good idea although my knowledge about them is very shallow, e.g. I am not sure what is the right way to detect that a field has no frequencies.
There was a problem hiding this comment.
Typically you would check FieldIndex#indexOptions. If the value is DOCS, then frequencies are not indexed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has happened a couple of times that we returned a wrong value here so let's make sure we have it covered.