Align doc value skipper interval boundaries when an interval contains a constant value #13597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a constant value
jpountz
approved these changes
Jul 22, 2024
.../test/org/apache/lucene/codecs/lucene90/TestLucene90DocValuesFormatVariableSkipInterval.java
Outdated
Show resolved
Hide resolved
5 tasks
linfn
pushed a commit
to linfn/lucene
that referenced
this pull request
Nov 5, 2024
… a constant value (apache#13597) keep adding documents to an skipper interval while it is dense and single valued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc values skipper currently creates a new interval every 4096 documents. This can be inefficient in the case that the field has low cardinality and values are sorted. In that case, we might want to align the boundaries for intervals that contains just a single value.
Therefore this change proposes to keep adding documents in an interval if the following conditions apply:
In this situation we will keep adding documents into the interval until one of the conditions break it.
relates #11432