hunspell: improve tolerateAffixRuleCountMismatches() for common problems #14239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems. When the user opts-in to tolerateAffixRuleCountMismatches(), it tolerates some, but not all affix mismatches. Support two cases: "EOF case": count is wrong and then we encounter end of file. previously the exception looked like this: java.text.ParseException: Premature end of rules for SFX B Y 2 "stampede case": in this case count is wrong and another instruction follows (such as another affix's rule). Previously, the exception looked like this: java.text.ParseException: Affix rule mismatch. Header: SFX A Y 2; rule: SFX B Y 2
|
using the |
dweiss
approved these changes
Feb 15, 2025
rmuir
added a commit
to rmuir/lucene
that referenced
this pull request
Feb 15, 2025
…ems (apache#14239) When the user opts-in to tolerateAffixRuleCountMismatches(), it tolerates some, but not all affix mismatches. Support two cases: "EOF case": count is wrong and then we encounter end of file. previously the exception looked like this: java.text.ParseException: Premature end of rules for SFX B Y 2 "stampede case": in this case count is wrong and another instruction follows (such as another affix's rule). Previously, the exception looked like this: java.text.ParseException: Affix rule mismatch. Header: SFX A Y 2; rule: SFX B Y 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user opts-in to tolerateAffixRuleCountMismatches(), it tolerates some, but not all affix mismatches. Support two cases:
"EOF case": count is wrong and then we encounter end of file. previously the exception looked like this:
"stampede case": in this case count is wrong and another instruction follows (such as another affix's rule).
Previously, the exception looked like this:
This PR should fix the issue in CI with the spanish dictionary (I think, we'll see). I will followup with the upstream.