LUCENE-10384: Simplify LongHeap small addition #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LUCENE-10384 and PR#615 introduced encoding f into NeighborQueue. But one function `nodes()` was remained to add this encoding. Also modify the test that would fail without this patch.
msokolov
reviewed
Jan 25, 2022
| HnswGraphBuilder builder = | ||
| new HnswGraphBuilder( | ||
| vectors, VectorSimilarityFunction.DOT_PRODUCT, 16, 100, random().nextInt()); | ||
| vectors, VectorSimilarityFunction.EUCLIDEAN, 16, 100, random().nextInt()); |
There was a problem hiding this comment.
can you explain why this test was failing? I'm concerned we somehow dropped support for DOT_PRODUCT now?
There was a problem hiding this comment.
or ... is the idea that you wanted to change the test so that it would verify the correctness of the ordering, because we didn't have any tests using EUCLIDEAN (ie inverted) scores before?
There was a problem hiding this comment.
@msokolov Right, that's correct. Sorry, the modified version of this test would fail without this patch.
There was a problem hiding this comment.
As EUCLIDEAD distance would use reverse ordering of NeighborQueue for results
mayya-sharipova
added a commit
that referenced
this pull request
Jan 27, 2022
LUCENE-10384 and PR#615 introduced encoding f into NeighborQueue. But one function `nodes()` was remained to add this encoding. Also modify the test that would fail without this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LUCENE-10384 and PR #615 introduced encoding into NeighborQueue.
But one function
nodes()the encoding was forgotten.Also modify the test that would fail without this patch.