Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MARCHETYPES-78] Set Java 8 as default Java version in archetype created projects instead of Java 7 #20

Closed
wants to merge 1 commit into from

Conversation

judovana
Copy link
Contributor

hi!

Similarly as in #18 the jdk7 bytecode is no longr viable in jdk21 world, and no one should be using jdk7.
Thus - much more simple then #18 - bulk bump of 1.7 maven compiler settings to 1.8
I can not swear that I had not missed any, but I did my best to not miss any.

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MARCHETYPES-XXX] SUMMARY, where you replace MARCHETYPES-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slachiewicz
Copy link
Member

what is the difference between this jira and the previous one MARCHETYPES-78 #18 ?

imho too many tickets with the same scope, "archetypes generate EOLed maven.compiler versions" Previously You have changed it to Java 7 and renamed directories also.

@slachiewicz slachiewicz added the dependencies Pull requests that update a dependency file label Dec 22, 2023
@judovana
Copy link
Contributor Author

The #18 was focusing only onec archetypes component - the quickstasrt - I did ti first, as it was a bit more compelx then the others.

This one is handling all others archetypes components. The original jira was named properly "maven-archetype-quickstart ...." - https://issues.apache.org/jira/browse/MARCHETYPES-76

The scond one https://issues.apache.org/jira/browse/MARCHETYPES-78 is handling all others.

@slachiewicz
Copy link
Member

superseded by #22

@judovana
Copy link
Contributor Author

judovana commented Dec 22, 2023

superseded by #22

Sorry it is not surpassed. The #22 It is doing revert of good thing and is mixing several parts together.

I think it would be better to propose 6141bad as standalone PR. Merge that. And then merge this one

@judovana
Copy link
Contributor Author

I see you have closed #22 , thank you. Can we reopen this please?

@slachiewicz slachiewicz reopened this Dec 22, 2023
@elharo
Copy link

elharo commented Dec 22, 2023

While I have no objection to selecting Java 8 by default instead of Java 7, I feel I need to keep repeating that Java 7 is not end of life. It is supported by and available from multiple vendors. Oracle != Java.

@elharo elharo changed the title [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [MARCHETYPES-78] Set Java 8 as default Java version in archetype created projects instead of Java 7 Dec 22, 2023
@judovana
Copy link
Contributor Author

judovana commented Dec 22, 2023

While I have no objection to selecting Java 8 by default instead of Java 7, I feel I need to keep repeating that Java 7 is not end of life. It is supported by and available from multiple vendors. Oracle != Java.

I think the pointing part is support of openjdk - last maintainer of openjdk7 was azul, and they dropped it.

https://github.com/openjdk/jdk7u "This repository has been archived by the owner on Apr 21, 2023. It is now read-only. " Maybe somebody is really doing it behind closed doors, but I'm not aware even of that (maybe except oracle, but I really dont know)

@judovana
Copy link
Contributor Author

will be reworked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants