[MCHECKSTYLE-346] Release a new version

[jira-importer]

richard opened MCHECKSTYLE-346 and commented

Hello,

Since my posts in another issue have gone unnoticed (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this one to bring it up front.

The main checkstyle community have been waiting years for a 2.18 release for fixes and functionality needed. As it is now, we cannot remove old deprecated code from our utility as the plugin relies on them too much and breaks if they are removed which forces us to continue supporting them just for you.
See Issue: checkstyle/checkstyle#2883

The last release for maven checkstyle plugin was 2015, but you continue to update the code base. Why is this? Is there something that prevents you from creating a new release? Do you lack personnel of some kind? Is it possible to give us a time table for a 2.18 release?

If things continue as they are now, we may begin looking into breaking compatibility with the plugin in newer versions as this project seems to have run stagnant and is lacking support. If compatibility is broken, the current plugin released will then only work with old and outdated versions. I, and I am sure the community, don't wish to see this happen but the checkstyle utility needs to keep evolving and remove outdated code.

---

Affects: 2.17

3 votes, 4 watchers

[jira-importer]

richard commented

As we have still not heard anything, we have started the process to break away from using maven-checkstyle-plugin in Checkstyle. Since it is the holiday season, we will wait until January before getting started. I suspect it may take us a month or so before we start incorporating serious backward breaking changes that will cause the plugin not to function with future versions of Checkstyle unless a new version of the maven plugin is released.

Here are some of the referenced issues:
checkstyle/contribution#273
checkstyle/checkstyle#5385
checkstyle/checkstyle#5386
checkstyle/checkstyle#2883

[jira-importer]

Robert Scholte commented

Hi richard, the message is clear. I wasn't aware of these issues. ( just to give you a hint about our issues ).
I think it should be possible to do a new release, let me have a look at this this period.
Also, speaking for myself, I think it would be an interesting idea to move the maven-checkstyle-plugin to the checkstyle project, so they can stay in sync.

[jira-importer]

Roman Ivanov commented

Hi Robert Scholte, thanks a lot for reply.

Checkstyle team is small, and not capable in sync all plugins of checkstyle, we already got ownership of Sonar plugin and have lack of time to keep it in sync too.
There are number of issues what are related to checkstyle and bunch of issues related to system that runs plugins (Sonar, maven,....). So it will be hard for one team to maintain the project alone.

What if some members (me and/or Richard) of Checkstyle team join to maven checkstyle plugin with ability to commit to it and release it, in this case we could help to upgrade plugin in changes related to checkstyle and Apache team still could help this plugin to upgrade in maven related changes.

[jira-importer]

Robert Scholte commented

Checkstyle team is small ...

We have the same issue with regard to active committers and comparing this with the code to maintain we're probably even in worse shape.

We cannot isolate access to just one plugin, so letting one of you join the team just to maintain this plugin is unlikely to happen.
I can think of several other solutions, but in the end it all depends how much control you want over this plugin and if the current situation is acceptable. This might require to ping the team when necessary.

[jira-importer]

Robert Scholte commented

https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/master/ plugin is stable now.
If there are other issues which should be part of this release, let me know.

[jira-importer]

Roman Ivanov commented

we're probably even in worse shape.

I do understand you. Just try to find compromise to avoid blocks.

I can think of several other solutions, but in the end it all depends how much control you want over this plugin and if the current situation is acceptable.

Please share your thoughts .... , we can provide fixes (migration for new versions of checkstyle, as we are in full context of how to make it), but it would be awesome for us to know when we can expect release of such fixes.
We are completely understand that release will not be immediate, but at least ones in few month, or any other trigger. I know that release process is not big fun for engineers, and is postponed as much as possible, and .... . But contributors will unlikely send you code if they know that release will take a while, so fork is better for them or do any other workaround.
Please share your thought and thanks lot for cooperation.

[jira-importer]

Roman Ivanov commented

If there are other issues which should be part of this release, let me know.

please update to 6.19 version of checkstyle

$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
     <maven.compiler.source>1.${javaVersion}</maven.compiler.source>
     <maven.compiler.target>1.${javaVersion}</maven.compiler.target>
     <mavenVersion>3.0</mavenVersion>
-    <checkstyleVersion>6.18</checkstyleVersion>
+    <checkstyleVersion>6.19</checkstyleVersion>
     <doxiaVersion>1.4</doxiaVersion>
     <sitePluginVersion>3.4</sitePluginVersion>
   </properties>

this is the last checkstyle release for jdk7.
it is good to do 2.18 plugin release in such state.

[jira-importer]

Roman Ivanov commented

It might be off topic here,
but it would be awesome to upgrade checkstyleVersion to 7.X release but this will require upgrade of plugin to jdk8 , as it was major update for Checkstyle http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 .
can you help us to upgrade to jdk8 parent poms and ..... , we will contribute all other checkstyle related update, I could create separate issue on this if you agree to help. I will be definitely for 2.19 release

[jira-importer]

Robert Scholte commented

Upgrading to Checkstyle 6.19 is not possible due to a failing integrationtest. Root cause is MCHECKSTYLE-322.
The plugin will be released as 3.0.0, since it drops Maven2 support.

For the next release based on JDK8 we can go to 3.1.0.

[jira-importer]

richard commented

Robert Scholte
Please release the plugin as it is now and let's close this issue. We will go from there by either opening new issues or pinging you on existing ones.
Since we are new to the project, there will probably be questions we will be asking as we to try to help out.
Thanks.

[jira-importer]

Robert Scholte commented

Vote has started, please verify: http://markmail.org/message/xrehu6lr2bloc2xs

[jira-importer]

Robert Scholte commented

Version 3.0.0 has been released