[MCHECKSTYLE-169] Suppressions property is incorrectly set if suppressions file is on classpath

[jira-importer]

Sergei S. Ivanov opened MCHECKSTYLE-169 and commented

If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.

---

Affects: 2.8

Attachments:

• MCHECKSTYLE-169-bugfix.patch (6.96 kB)
• MCHECKSTYLE-169-it.patch (10.53 kB)

Issue Links:

• MCHECKSTYLE-149 supressionsFileExpression does not work.

5 votes, 6 watchers

[jira-importer]

Sergei S. Ivanov commented

Related to some prior changes, but the problem is that an unresolved (as in the plugin config) file path is passed into checkstyle engine, whereas the resolved file path (see getSuppressions() method) is not used.

[jira-importer]

Dennis Lundberg commented

Can you give a sample project that we can use to test this?

[jira-importer]

Sergei S. Ivanov commented

Hello Dennis,
Attached are an integration test for the described problem and a patch that fixes it. I wanted to add a couple of additional integration tests to check for regressions, but ran out of spare time. Please review and integrate into the next release if deemed suitable. The patch is against the SVN trunk for the plugin.
Thank you.

[jira-importer]

Sergei S. Ivanov commented

Any chance of the attached patch being integrated into 2.10?

[jira-importer]

Sergei S. Ivanov commented

Please, please!

[jira-importer]

Sergei S. Ivanov commented

Can we have it integrated into 2.11, please?

[jira-importer]

Edwin Shin commented

This was driving me nuts (using version 2.10). Is there any workaround in the meantime (e.g. is this a regression and is there an older version in which this does work)?

[jira-importer]

Sergei S. Ivanov commented

Can it be integrated into 2.12, please? It is frustrating that the issue is still unresolved after 2 years, despite a patch being available. We have effectively given up on Checkstyle integration into our Maven/Jenkins reports because of that.

[jira-importer]

Dennis Lundberg commented

Patch applied in r1570730. Many thanks!

[jira-importer]

Dmitry Katsubo commented

Before v2.12 (that included this patch) it was possible to set <suppressionsLocation> to some location, that does not necessarily exist in particular project. This is handy e.g. during multi-module build, when some of the projects have that file, and some ? don't. Now the location should exist. How to make this setting optional (e.g. if suppressions file exists then it is used, otherwise the build does not fail)?