[MDEPLOY-202] deploy-file goal insists on deploying source file for previous deploy-file execution

[jira-importer]

Stephan Leicht Vogt opened MDEPLOY-202 and commented

In a releng pom I deploy various files to a repository. Each file is in its own execution. Beside the binary file I also want to deploy the source jar:

<profile>
  <id>deploy-equinox-snapshots</id>
  <activation>
    <activeByDefault>true</activeByDefault>
  </activation>
  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-deploy-plugin</artifactId>
        <executions>
          <execution>
            <id>deploy-osgi</id>
            <goals>
              <goal>deploy-file</goal>
            </goals>
            <phase>deploy</phase>
            <configuration>
              <file>${downloaded}/org.eclipse.osgi_${org.eclipse.osgi}.jar</file>
              <sources>${downloaded}/org.eclipse.osgi.source_${org.eclipse.osgi}.jar</sources>
              <pomFile>${project.build.outputDirectory}/org.eclipse.osgi.pom</pomFile>
            </configuration>
          </execution>
          <execution>
            <id>deploy-equinox-common</id>
            <goals>
              <goal>deploy-file</goal>
            </goals>
            <phase>deploy</phase>
            <configuration>
              <file>${downloaded}/org.eclipse.equinox.common_${org.eclipse.equinox.common}.jar</file>
              <sources>${downloaded}/org.eclipse.equinox.common.source_${org.eclipse.equinox.common}.jar</sources>
              <pomFile>${project.build.outputDirectory}/org.eclipse.equinox.common.pom</pomFile>
            </configuration>
          </execution>
          <execution>
            <id>deploy-equinox-security</id>
            <goals>
              <goal>deploy-file</goal>
            </goals>
            <phase>deploy</phase>
            <configuration>
              <file>${downloaded}/org.eclipse.equinox.security_${org.eclipse.equinox.security}.jar</file>
              <sources>${downloaded}/org.eclipse.equinox.security.source_${org.eclipse.equinox.security}.jar</sources>
              <pomFile>${project.build.outputDirectory}/org.eclipse.equinox.security.pom</pomFile>
            </configuration>
          </execution>
          <execution>
            <id>deploy-equinox-registry</id>
            <goals>
              <goal>deploy-file</goal>
            </goals>
            <phase>deploy</phase>
            <configuration>
              <file>${downloaded}/org.eclipse.equinox.registry_${org.eclipse.equinox.registry}.jar</file>
              <sources>${downloaded}/org.eclipse.equinox.registry.source_${org.eclipse.equinox.registry}.jar</sources>
              <pomFile>${project.build.outputDirectory}/org.eclipse.equinox.registry.pom</pomFile>
            </configuration>
          </execution>
          <execution>
            <id>deploy-equinox-preferences</id>
            <goals>
              <goal>deploy-file</goal>
            </goals>
            <phase>deploy</phase>
            <configuration>
              <file>${downloaded}/org.eclipse.equinox.preferences_${org.eclipse.equinox.preferences}.jar</file>
              <sources>${downloaded}/org.eclipse.equinox.preferences.source_${org.eclipse.equinox.preferences}.jar</sources>
              <pomFile>${project.build.outputDirectory}/org.eclipse.equinox.preferences.pom</pomFile>
            </configuration>
          </execution>
        </executions>
      </plugin>
    </plugins>
  </build>
</profile>

The first execution works fine but every other execution deploys again the source files from all past executions. Although this works for SNAPSHOTS it breaks for RELEASES as a released file shouldn't/can't be overwritten.

---

Affects: 2.8.1, 2.8.2

Attachments:

• MDEPLOY-202-DeployFileMojo.patch (521 bytes)

This issue is a sub-task of MDEPLOY-143

[jira-importer]

Stephan Leicht Vogt commented

This solves the described issue.

[jira-importer]

Karl Heinz Marbaise commented

Can you provide a full example project which shows the behaviour ?

[jira-importer]

Stephan Leicht Vogt commented

Here is the full pom: https://git.eclipse.org/c/scout/org.eclipse.scout.sdk.git/tree/org.eclipse.scout.sdk.s2e.releng/pom.xml?h=releases/5.2.x

And here the broken build where I wanted to deploy the "release" versions of the dependencies: https://hudson.eclipse.org/scout/job/org.eclipse.scout.sdk.dependencies/20/console

[jira-importer]

Stephan Leicht Vogt commented

What is the state of this issue? Can I help somehow? I depend on a solution of this as I don't see a (easy) workaround.

[jira-importer]

Robert Scholte commented

If these are all files with the same groupId/artifactId/version, then the correct solution is to use http://www.mojohaus.org/build-helper-maven-plugin/attach-artifact-mojo.html

[jira-importer]

Stephan Leicht Vogt commented

This doesn't work as all files have different artifactIds and versions.

What about the patch I provided? Why can't it be applied and a new version of this plugin released?

[jira-importer]

Robert Scholte commented

That will the status of the current MavenProject. And I know that someone will ask for the same solution with the maven-install-plugin, so that should be a sign that this is not the correct solution.
IMHO it is still wrong to use deploy-file as part of the build-lifecycle. These jars are static, so there's no need to upload them as part of the lifecycle, right?
deploy-file was very useful in the past when there were no good repository manager GUIs which gave you the option to upload artifacts.

However, I think there's indeed an issue with the code: it should not abuse the current MavenProject. It would be better to create a new MavenProject instance in case of the deploy-file goal.

[jira-importer]

Robert Scholte commented

Fixed in r1709276

[jira-importer]

Stephan Leicht Vogt commented

Thanks, unfortunately I can't test it as org.apache.maven.plugins:maven-plugins:pom:28-SNAPSHOT doesn't seem to be deployed on http://repository.apache.org/snapshots:
https://hudson.eclipse.org/scout/job/org.eclipse.scout.sdk.dependencies/24/console

[jira-importer]

Robert Scholte commented

maven-plugins:28 has been released, so the SNAPSHOT has been removed. I've updated the pom of the maven-deploy-plugin.

[jira-importer]

Stephan Leicht Vogt commented

This worked so far. But now I get the next error. It seems the deploy-plugin doesn't use the authentication entries from the settings.xml. Here the log with debug output: https://hudson.eclipse.org/scout/job/org.eclipse.scout.sdk.dependencies/26/console

[jira-importer]

Robert Scholte commented

Good catch! That part has been rewritten, so we can use Aether more efficiently (hence the 3.0 version). Should be fixed with r1709672

[jira-importer]

Stephan Leicht Vogt commented

Great, it works! Thank you very much.
BUILD SUCCESS: https://hudson.eclipse.org/scout/job/org.eclipse.scout.sdk.dependencies/27/

[jira-importer]

Matthias Hanisch commented

Sorry to jump in late.

We got also hit by the issue above and I gave it a quick try to check if our scenario is really solved with the upcoming 3.0.0 of deploy plugin.
I created a very simple jar project with a hello world class and a accompanying bill of materials which should be additionally uploaded using deploy-file goal.

The pom attaches sources and javadoc jar, executes "default-deploy" to upload the "hello world" jar and also executes a deploy-file to upload the corresponding bom.
The "deploy-bom" still uploads sources and javadoc jar again, even with 3.0.0-SNAPSHOT.

Let me just attach the relevant plugin configurations. If more information is required or if I should create a new issue just let me know.

<!-- Attach sources and javadoc -->
<plugin>
	<artifactId>maven-javadoc-plugin</artifactId>
	<version>2.10.4</version>
	<executions>
		<execution>
			<id>attach-javadocs</id>
			<goals>
				<goal>jar</goal>
			</goals>
		</execution>
	</executions>
</plugin>
<plugin>
	<artifactId>maven-source-plugin</artifactId>
	<version>3.0.0</version>
	<executions>
		<execution>
			<id>attach-sources</id>
			<goals>
				<goal>jar</goal>
			</goals>
		</execution>
	</executions>
</plugin>

<!-- upload bom with the jar -->
<plugin>
	<artifactId>maven-deploy-plugin</artifactId>
	<version>3.0.0-SNAPSHOT</version>
	<configuration>
		<url>${project.distributionManagementArtifactRepository.url}</url>
		<repositoryId>${project.distributionManagementArtifactRepository.id}</repositoryId>
	</configuration>
	<executions>
		<execution>
			<id>deploy-bom</id>
			<phase>deploy</phase>
			<goals>
				<goal>deploy-file</goal>
			</goals>
			<configuration>
				<file>${project.basedir}/bom/pom.xml</file>
				<pomFile>${project.basedir}/bom/pom.xml</pomFile>
			</configuration>
		</execution>
	</executions>
</plugin>

[jira-importer]

Matthias Hanisch commented

Looking at the commit for this issue it seems to me that this really does not fix my case where the attachment was not added within a deploy-file configuration but within the normal project lifecycle - in my case by maven-source-plugin and maven-javadoc-plugin.