[MRESOLVER-29] Move ant tasks into master as new module

[jira-importer]

Manfred Moser opened MRESOLVER-29 and commented

The ant tasks of Maven Resolver are currently in a separate branch. This makes it hard to keep version consistent and is also harder to understand and locate for users in apache git and on github.

---

Issue Links:

• MRESOLVER-28 Move demos into master as new module
  ("Is contained by")
• MRESOLVER-37 Release ant-tasks

[jira-importer]

Manfred Moser commented

Moved into subfolder and pushed into new branch ant-tasks-folder

[jira-importer]

Manfred Moser commented

More comments in linked issue

[jira-importer]

Hervé Boutemy commented

as explained on dev list and MRESOLVER-29, I'm not convinced that we should move ant tasks into master since:

1. they need to be published to central as consumable artifact
2. there is a dependency on Maven core's Maven Resolver Provider that will in general cause strange dependency version subtle differences, and in incompatible change case even cause un-releasable ant tasks in some resolver release

[jira-importer]

Manfred Moser commented

The ant tasks are published (installed and deployed) as normal so there is no issue.

The second issue indicated seems more a code and dependency problem than a reason to keep it in a separate branch. Looking at the pom the shade plugin is used to create an uber jar and there is all sorts of funky relocation and stuff happening. I have a feeling we should merge this all into one branch and then work on cleaning this uber jar up more. mavenVersion is already set at 3.5.0 and we should therefore be able to get rid of a lot of this magic since all the relocation work is no longer needed with 3.5.2 and in the ant runtime context it can all be just consistently with newer versions instead of trying be compatible with old maven versions and dealing with the funky moves of resolver to sonatype, to eclipse and back to apache.

I think if the ant tasks are not releasable at any time the resolver should not be released either and having them all in one multi module project expresses that idea better.

The main reason I did the change is so that it is easier to see the code all in one place and work with it as well as cleaner for the user and to maintain as an overall project. Wdyt?

Also if there are specific changes for the ant task I can do to fix the dependency version issues I can attack them after the merge and prior to the next release.

[jira-importer]

Manfred Moser commented

We had a longer discussion about this on the dev mailing list and it turns out that there is a ciruclar dependency between maven-resolver, maven (maven-resolver-provider to be precise) and maven-resolver-ant-task. Breaking this up is too much work for now.

As a result we came to the conclusion to either leave the ant tasks in the branch for now or give it a separate top level repository. I will see what it takes to get it its own repo.

[jira-importer]

Manfred Moser commented

The related move of the demos is completed.

[jira-importer]

Manfred Moser commented

We decided to move the ant tasks to new top level repo. This is now done and available at https://github.com/apache/maven-resolver-ant-tasks and gitbox.

For this issue I think the only thing missing are probably changes for CI setup (not sure who can do that) and deleting the branch in the old repo.

At this stage the build works and looking at Central I think there is no 1.1.0 release of the ant tasks (or any for that matter). http://repo1.maven.org/maven2/org/apache/maven/resolver/

I think we should cut that release (and do that as a separate issue)

[jira-importer]

Manfred Moser commented

CI setup now exists. I deleted the ant-tasks branch in the original repo. The new repo is ready to be used for a release for which I created https://issues.apache.org/jira/browse/MRESOLVER-37