Skip to content

[MRESOLVER-228] Proposed changes #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[MRESOLVER-228] Proposed changes #137

wants to merge 3 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 27, 2021

Proposed changes for #136

@caiwei-ebay please take a look

Changes:

  • cleanup
  • do not create reconciler when not used (moved tiny logic)
  • clean up flow in two cases (reconciler used and reconciler not used)

@cstamas cstamas requested a review from michael-o November 27, 2021 19:14
@cstamas cstamas self-assigned this Nov 27, 2021
@cstamas cstamas mentioned this pull request Nov 27, 2021
Closed
michael-o
michael-o requested changes Nov 27, 2021
View reviewed changes
...-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
);
if ( useSkipReconcile )
{
LOGGER.debug( "Collector skip & reconcile enabled." );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think such a message is redundant as well because the user explicitly wanted to skip this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was present in original PR by @caiwei-ebay so let's wait for his response here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-o @cstamas

Thanks for reviewing and updating the PR.

I provide a property just for compatibility consideration. As I'm confident with the "skip & reconcile" approach as we've dryrun 2000+ applications in our company, so I would raise both hands in favour of that we don't provide a property to disable this behavior.

@caiwei-ebay
Copy link
Contributor

@michael-o @cstamas

The code changes looks good to me and it's much cleaner. Thanks for updating the PR.
Is there anything I can help further before you folks accept the PR?

Thanks,
caiwe-ebay

@michael-o
Copy link
Member

@caiwei-ebay Please integrate this into your PR first, then we will continue.

@michael-o
Copy link
Member

Integrated into upstream branch.

@michael-o michael-o closed this Dec 2, 2021
@michael-o michael-o deleted the cstamas-mresolver-228 branch December 2, 2021 20:13
@jira-importer
Copy link

Resolve #1407

1 similar comment
@jira-importer
Copy link

Resolve #1407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o requested changes

+1 more reviewer

@caiwei-ebay caiwei-ebay caiwei-ebay left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cstamas cstamas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cstamas @caiwei-ebay @michael-o @jira-importer