Skip to content

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Sep 18, 2025

Apply same strategy to classpath collection as we apply to dependency collection ("nearest wins").

@cstamas cstamas self-assigned this Sep 18, 2025
@cstamas cstamas marked this pull request as ready for review September 18, 2025 12:01
@cstamas cstamas marked this pull request as draft September 18, 2025 20:26
@cstamas
Copy link
Member Author

cstamas commented Sep 18, 2025

cstamas and others added 4 commits September 19, 2025 16:19
Apply same strategy to classpath collection as we apply to
dependency collection ("nearest wins").
…ionProperties.java

Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
They should NOT be embedded into viltering visitor ever
(level order loses context, other two are not really affected)
instead they got support for filtering.
@cstamas cstamas force-pushed the dep-visitor-levelorder branch from b65a91a to 2bcbe74 Compare September 19, 2025 14:19
@cstamas cstamas marked this pull request as ready for review September 19, 2025 14:29
@cstamas cstamas added this to the 2.0.12 milestone Sep 19, 2025
@cstamas cstamas added enhancement New feature or request and removed not for merge labels Sep 19, 2025
@cstamas
Copy link
Member Author

cstamas commented Sep 19, 2025

Requires update to MavenITmng3813PluginClassPathOrderingTest as it is the only IT that will with this PR fail, as it assers exact classpath ordering, but it uses preOrder assumption.

@cstamas cstamas merged commit 80e0d60 into apache:master Sep 19, 2025
8 checks passed
@cstamas cstamas deleted the dep-visitor-levelorder branch September 19, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants