Allow scripting in files #1
Conversation
Removed SNAPSHOT as it seems a complete version.
|
Hi @rpopov our JIRA is public, you can freely subscribe. |
pom.xml
Outdated
| @@ -30,12 +30,13 @@ under the License. | |||
| </parent> | |||
|
|
|||
| <artifactId>maven-scripting-plugin</artifactId> | |||
| <version>3.0.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
This will be change during release. Please revert
There was a problem hiding this comment.
3.0.0 is correct, this is the first release of the plugin, compatible with Maven 3
| @@ -92,13 +93,6 @@ under the License. | |||
| <scope>provided</scope> | |||
| </dependency> | |||
|
|
|||
| <!-- ScriptEngines --> | |||
| <dependency> | |||
There was a problem hiding this comment.
This will be an important change for users, it should be another ticket, please create a separate patch.
Btw why don't you want this one on the classpath?
There was a problem hiding this comment.
I think that the groovy script interpreter is not necessary for the compilation and running of the plugin/ Instead it imposes the download of a significant graph of dependencies. The plugin allows using other than groovy languages and should treat them equally.
The groovy sccript interpreter is moved to the test poms.
There was a problem hiding this comment.
Btw, there is no previous version of the plugin published on Maven Central, its version is 3.0.0-SNAPSHOT which assumes interface changes, that are not finalized. Now is the time to avoid using groovy.
There was a problem hiding this comment.
For Maven the versioning scheme works a bit different. The 3.x.x means this plugin requires at least Maven 3. If we break backwords compatibility it is for the next Maven version.
This scheme has proven itself over the years, now there's no confusion anymore if a certain plugin works with Maven 2 or not.
There was a problem hiding this comment.
@rpopov as we never released this plugin to the public I am fine with dropping the dependency now
|
|
closing and reopening in order to trigger Travis |
|
@rpopov we are enabling Travis-CI on this github project, so that you can see the results of the tests directly in Travis. |
|
This project is still very new, I found that we don't have even the JIRA project yet, I apologize for having given you bad instructions. |
There was a problem hiding this comment.
thank you @rpopov
Looks good,
please fix the typo as I have suggested.
In order to merge this PR I need to setup JIRA and a bunch of other things.
@rfscholte I will be happy to release the first version as soon as we are ready with all the INFRA stuff
| @@ -92,13 +93,6 @@ under the License. | |||
| <scope>provided</scope> | |||
| </dependency> | |||
|
|
|||
| <!-- ScriptEngines --> | |||
| <dependency> | |||
There was a problem hiding this comment.
@rpopov as we never released this plugin to the public I am fine with dropping the dependency now
|
@rpopov I am sorry, we still have to wait for JIRA setup. |
|
meanwhile can you please squash everything into 1 single commit and rebase onto current master ? |
|
closing in favour of #3 |
Once MSCRIPTING JIRA project is not public, I was not able to register a JIRA issue for this change.
Added parameter to maven-scripting-plugin, allowing the identification of the engine to use to use the file name extension, while still allowing explicitly naming the engine by providing . Internally refactored to have a cleaner structure, allowing more extensions.