Skip to content

[MSCRIPTING-15] require maven 3.6.3 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Mar 2, 2024

Requires #10 to be marged first (this one is based on that branch).
Background: don't want yet another PR for the requirement history, should be done in this PR.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSCRIPTING-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSCRIPTING-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell requested review from hboutemy and rmannibucau March 2, 2024 13:22
@bmarwell bmarwell force-pushed the MSCRIPTING-15-maven-3.6.3 branch from 2d7a0d4 to df1efb0 Compare March 2, 2024 21:52
@bmarwell bmarwell merged commit 7210b3b into master Mar 2, 2024
@bmarwell bmarwell deleted the MSCRIPTING-15-maven-3.6.3 branch March 2, 2024 21:52
@bmarwell bmarwell added this to the 3.1.0 milestone Mar 2, 2024
@jira-importer
Copy link

Resolve #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants