Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8081] Profile property activation interpolation #1477

Closed
wants to merge 4 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Apr 21, 2024

Property profile activation should interpolate.


https://issues.apache.org/jira/browse/MNG-8081

@cstamas cstamas self-assigned this Apr 21, 2024
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@mbenson
Copy link
Contributor

mbenson commented Apr 22, 2024

I notice that this implementation only interpolates properties in property activations, whereas my submitted implementations for both v3.9.x and v4 attempt to satisfy the "least surprise" principle by applying interpolations to all properties among every profile activation type. IMHO that's the best way forward but I am satisfied if this PR becomes the 3.9.x implementation.

@cstamas
Copy link
Member Author

cstamas commented Apr 22, 2024

@mbenson can you clarify what you mean by "only [...] property activations" vs "all property activations" as I think don't understand it fully wdym here...

@mbenson
Copy link
Contributor

mbenson commented Apr 22, 2024

Sorry @cstamas, was working late and apparently not 100%. Edited my comment with changed text in bold.

Further context: there are system/user/project (in your implementation) properties, and then there are properties of the objects comprising the project model. So an activation has properties whose (string) values may be interpolated from the "environmental" properties. Does that help?

@gnodet
Copy link
Contributor

gnodet commented Apr 25, 2024

Duplicates #1447

@gnodet gnodet closed this Apr 25, 2024
@cstamas cstamas deleted the maven-3.9.x-MNG-8081 branch April 26, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants