Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects #816

Closed
wants to merge 3 commits into from

Conversation

cestella
Copy link
Member

Contributor Comments

The version bump missed a couple of projects that were added between when the PR for the version bump was created and when it was committed.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@justinleet
Copy link
Contributor

+1 by inspection, pending Travis

1 similar comment
@mattf-apache
Copy link
Member

+1 by inspection, pending Travis

@mmiklavc
Copy link
Contributor

+1 by inspection

@mmiklavc
Copy link
Contributor

I just found a few more references to 0.4.1. We should probably change paths from explicit version paths to $METRON_HOME in README's. We probably don't want to tackle this here. We should fix the build first and foremost and follow up with another Jira/PR.

~/devprojects/metron-commits:master ✓ ➭ grep -R "0\.4\.1" --include \*.md .
./metron-analytics/metron-profiler/README.md:    metron-deployment//packaging/docker/rpm-docker/RPMS/noarch/metron-profiler-0.4.1-201707131420.noarch.rpm
./metron-analytics/metron-profiler/README.md:    /localrepo/metron-profiler-0.4.1-201707112313.noarch.rpm
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/bin
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/bin/start_profiler_topology.sh
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/config
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/config/profiler.properties
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/flux
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/flux/profiler
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/flux/profiler/remote.yaml
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/lib
./metron-analytics/metron-profiler/README.md:    /usr/metron/0.4.1/lib/metron-profiler-0.4.1-uber.jar
./metron-analytics/metron-profiler-client/README.md:[root@node1 0.4.1]# bin/stellar -z node1:2181

@cestella
Copy link
Member Author

I found a couple of refs to 0.4.1 in the profiler READMEs. I went ahead and corrected them while I was in there.

@mattf-apache
Copy link
Member

@mmiklavc and @cestella regarding "0.4.1" references in README.md files, please see #767 , specifically Otto's comment #767 (comment) and my response #767 (comment)

@cestella
Copy link
Member Author

Yeah, I agree that it doesn't materially affect the example. I decided to adjust it anyway excepting the names of the rpms. Perhaps I should revert the commit. Thoughts?

@mmiklavc
Copy link
Contributor

@cestella @mattf-horton - I don't think the commit hurts anything, so no point in removing it now that it's in. But I do agree with otto that it would be better to use $METRON_HOME and that this could be handled by a separate PR.

@mattf-apache
Copy link
Member

Agree with @mmiklavc comment.

@justinleet
Copy link
Contributor

I agree we leave it as-is.

@asfgit asfgit closed this in 128d4e7 Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants