-
Notifications
You must be signed in to change notification settings - Fork 507
METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects #816
Conversation
+1 by inspection, pending Travis |
1 similar comment
+1 by inspection, pending Travis |
+1 by inspection |
I just found a few more references to 0.4.1. We should probably change paths from explicit version paths to $METRON_HOME in README's. We probably don't want to tackle this here. We should fix the build first and foremost and follow up with another Jira/PR.
|
I found a couple of refs to 0.4.1 in the profiler READMEs. I went ahead and corrected them while I was in there. |
@mmiklavc and @cestella regarding "0.4.1" references in README.md files, please see #767 , specifically Otto's comment #767 (comment) and my response #767 (comment) |
Yeah, I agree that it doesn't materially affect the example. I decided to adjust it anyway excepting the names of the rpms. Perhaps I should revert the commit. Thoughts? |
@cestella @mattf-horton - I don't think the commit hurts anything, so no point in removing it now that it's in. But I do agree with otto that it would be better to use $METRON_HOME and that this could be handled by a separate PR. |
Agree with @mmiklavc comment. |
I agree we leave it as-is. |
Contributor Comments
The version bump missed a couple of projects that were added between when the PR for the version bump was created and when it was committed.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.