-
Notifications
You must be signed in to change notification settings - Fork 376
bsp/pinetime: Add bsp for PineTime smartwatch #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I have some questions I posted on the comments.
fa0029b
to
623fc0a
Compare
This adds the bsp boilerplate including the pin definitions for the peripherals.
36dce8e
to
89c3805
Compare
I split the documentation into a seperate PR in the hope to make progress on the BSP while the docs are discussed #2254 |
Style check summaryNo suggestions at this time! |
RAT Report (2020-03-29 11:11:24)New files with unknown licenses11 new files were excluded from check (.rat-excludes)Detailed analysisNew files in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
bsp.linkerscript.BOOT_LOADER.OVERWRITE: | ||
- "hw/bsp/pinetime/boot-pinetime.ld" | ||
- "@apache-mynewt-core/hw/mcu/nordic/nrf52xxx/nrf52.ld" | ||
bsp.part2linkerscript: "hw/bsp/pinetime/split-pinetime.ld" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the split-pinetime.ld
file???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line should not be there. I think this is supposed to be part of split images. But this is currently not implemented for PineTime.
This adds the bsp boilerplate including the pin definitions for the peripherals. A description of the device can be found here: https://wiki.pine64.org/index.php/PineTime
I plan to add drivers for the peripherals later.