Skip to content

Conversation

caspermeijn
Copy link
Contributor

This adds the bsp boilerplate including the pin definitions for the peripherals. A description of the device can be found here: https://wiki.pine64.org/index.php/PineTime

I plan to add drivers for the peripherals later.

@mlaz mlaz self-requested a review March 27, 2020 15:44
Copy link
Contributor

@mlaz mlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I have some questions I posted on the comments.

This adds the bsp boilerplate including the pin definitions for the
peripherals.
@caspermeijn caspermeijn force-pushed the bsp-pinetime branch 2 times, most recently from 36dce8e to 89c3805 Compare March 29, 2020 11:07
@caspermeijn
Copy link
Contributor Author

I split the documentation into a seperate PR in the hope to make progress on the BSP while the docs are discussed #2254

@apache-mynewt-bot
Copy link

Style check summary

No suggestions at this time!

@apache-mynewt-bot
Copy link

RAT Report (2020-03-29 11:11:24)

New files with unknown licenses

11 new files were excluded from check (.rat-excludes)

Detailed analysis

New files in this PR

License File
????? hw/bsp/pinetime/boot-pinetime.ld
AL hw/bsp/pinetime/bsp.yml
AL hw/bsp/pinetime/pinetime.ld
AL hw/bsp/pinetime/pinetime_debug.sh
AL hw/bsp/pinetime/pinetime_download.sh
AL hw/bsp/pinetime/pkg.yml
AL hw/bsp/pinetime/syscfg.yml
AL hw/bsp/pinetime/include/bsp/bsp.h
AL hw/bsp/pinetime/src/hal_bsp.c
AL hw/bsp/pinetime/src/sbrk.c

Copy link
Contributor

@mlaz mlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@mlaz mlaz merged commit 220ddec into apache:master Mar 29, 2020
@caspermeijn caspermeijn deleted the bsp-pinetime branch March 30, 2020 17:40
bsp.linkerscript.BOOT_LOADER.OVERWRITE:
- "hw/bsp/pinetime/boot-pinetime.ld"
- "@apache-mynewt-core/hw/mcu/nordic/nrf52xxx/nrf52.ld"
bsp.part2linkerscript: "hw/bsp/pinetime/split-pinetime.ld"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the split-pinetime.ld file???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should not be there. I think this is supposed to be part of split images. But this is currently not implemented for PineTime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants