Included node_modules

[jhs]

Hi, Nuno. Is it correct to include node_modules in the Git code? I thought that is out of scope for source builds (obviously it is put there by npm install but that is a "binary build" IMO).

In my own code I always put node_modules in the .gitignore however I have no idea if that is correct or not.

Any thoughts?

[dscape]

The objective here was simplicity. A simple git clone is enough to get you started with nano.

If you check nano git ignore you will see that I have node_modules there. However I added it after versioning request and underscore, cause I felt like it was ok to keep them there. In other words this was deliberate :)

The current version of request is still unpublished in npm, so that can't match. That includes fixes for proxy authentication, StrictSSL, and several global vars leaks to cover just some of the cases.

I can remove the versioning of request if you like, just considered simpler to have it for now. If you feel strongly about it send in a pull request :)

[jhs]

No, I think you make a good point.

[mikeal]

I actually check all my dependencies in to git in node_modules.

It makes collaboration easier, you can see diffs for the changes in dependencies when you upgrade the version.

-Mikeal

On Sep 20, 2011, at September 20, 20118:43 AM, Jason Smith wrote:

Hi, Nuno. Is it correct to include node_modules in the Git code? I thought that is out of scope for source builds (obviously it is put there by npm install but that is a "binary build" IMO).

In my own code I always put node_modules in the .gitignore however I have no idea if that is correct or not.

Any thoughts?

Reply to this email directly or view it on GitHub:
#20

[jhs]

@mikeal And then when you npm publish they are simply not bundled, I presume?

That's pretty cool.

[mikeal]

Well, you can do a bundle push that will bundle them, but they won't be bundled if you don't do that kind of push.

For deployment, IMO, you should always do a bundle push of all your pure-js deps. Deps that have to be compiled are another story tho.

The only place this all gets complicated is when you're using npm link and developing the dependency as well. git won't follow sym links :(

-Mikeal

On Sep 20, 2011, at September 20, 201110:28 AM, Jason Smith wrote:

@mikeal And then when you npm publish they are simply not bundled, I presume?

That's pretty cool.

Reply to this email directly or view it on GitHub:
#20 (comment)