Updating to HTML/Java API version 1.7 #1738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtulach
reviewed
Dec 5, 2019
| <os family="windows"/> | ||
| </condition> | ||
| <exec executable="${maven.embedder.dir}/maven/bin/mvn${.cmd}" failonerror="true"> | ||
| <arg value="-DforcedVersion=SNAPSHOT"/> |
There was a problem hiding this comment.
@jglick, please take a look.
There was a problem hiding this comment.
So just replacing SNAPSHOT with dev-SNAPSHOT? Seems fine.
jtulach
referenced
this pull request
in jtulach/netbeans
Dec 5, 2019
jtulach
reviewed
Dec 5, 2019
| </target> | ||
|
|
||
| <target name="patch-for-maven" depends="init" description="Patch local Maven repo's -DmavenVersion of this module with one built from sources."> | ||
| <target name="patch-for-maven" depends="maven-install"/> <!-- deprecated --> |
There was a problem hiding this comment.
@jglick, I was always wondering what patch-for-maven target stands for. After many years I finally took a look and found out that it is the task I was always looking for. Probably a sign the target's name isn't best. I propose to name it maven-install.
jglick
reviewed
Dec 6, 2019
| <os family="windows"/> | ||
| </condition> | ||
| <exec executable="${maven.embedder.dir}/maven/bin/mvn${.cmd}" failonerror="true"> | ||
| <arg value="-DforcedVersion=SNAPSHOT"/> |
There was a problem hiding this comment.
So just replacing SNAPSHOT with dev-SNAPSHOT? Seems fine.
sdedic
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to update to new version of HTML/Java API which has been released in November.
OracleLab's IGV is currently using 1.6.1 (bundled together with NetBeans 11.2) and we run into a GC related problem of premature release of the model objects: fix by this change.
The fix is part of NetBeans HTML/Java API version 1.7 - hence upgrading to it (in NetBeans as well as IGV) shall fix our problems.