Handling of switch expressions and rule cases in Flow and NPECheck hint. #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlahoda
added
the
Java
| private void breakTo(Tree target) { | ||
| resumeAfter(target, variable2State); | ||
|
|
||
| variable2State = new HashMap< Element, State>(); |
There was a problem hiding this comment.
Jackpot:
warning: Redundant type arguments in new expression (use diamond operator instead).
jlahoda
commented
Aug 5, 2020
java/java.hints/src/org/netbeans/modules/java/hints/introduce/Flow.java
Outdated
Show resolved
Hide resolved
sdedic
reviewed
Sep 11, 2020
| Boolean result = super.scan(tree, p); | ||
| Boolean result; | ||
|
|
||
| if (tree != null) { |
There was a problem hiding this comment.
Wouldn't it be beneficial to build the visitSwitchExpression and visitYield into baseclasses ?
lkishalmi
approved these changes
Oct 22, 2020
lkishalmi
pushed a commit
that referenced
this pull request
Oct 23, 2020
…nt. (#2293) * Handling of switch expressions and rule cases in Flow and NPECheck hint. * Using a correct overload if TreeScanner.scan * Fixing FlowTest on JDK 8. * Attempting to improve stability of HideFieldByVarTest. * Using a diamond instead of explicit type parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.