New from Template for VSCode. #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
changed the title
sdedic
reviewed
Apr 14, 2021
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
force-pushed
the
jtulach/NewFromTemplateForVSCode
branch
from
40e210f
to
819c639
Compare
sdedic
reviewed
Apr 14, 2021
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Show resolved
Hide resolved
added 6 commits
April 22, 2021 05:31
…all without errors in commit validation
JaroslavTulach
force-pushed
the
jtulach/NewFromTemplateForVSCode
branch
from
d8af4f4
to
7dc2f78
Compare
|
I removed the f8116fa commit - that is a separate issue and not everyone agrees to merge it as it is. Otherwise I believe this is ready for integration. |
sdedic
approved these changes
Apr 22, 2021
ide/xml/src/org/netbeans/modules/xml/resources/templates/emptyXML.xml.template
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java
Show resolved
Hide resolved
It was quite simple with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
DataObject.createFromTemplatefor simple templates fromTemplatesfolder to VSCode users in a simple few step UI. CCing @Ondrej-Douda, @jisedlacSelect the New from Template... item and:
At the end new file opens in the editor. Testing extension is available at its jenkins builder and is updated with every change to this PR.