Skip to content

[NETBEANS-860] Hints: Update test cases #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[NETBEANS-860] Hints: Update test cases #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be091e
[NETBEANS-860] Hints: Update test cases
vikasprabhakar Aug 16, 2018
495a051
[NETBEANS-860] Hints: Update test cases
vikasprabhakar Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions java.hints/test/unit/src/org/netbeans/modules/java/hints/suggestions/Bundle_test.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,5 @@ ERR_splitIfCondition=ERR_splitIfCondition

HINT_ConvertIfToSwitch=HINT_ConvertIfToSwitch
FIX_ConvertIfsToSwitch=FIX_ConvertIfsToSwitch

ERR_ConvertVarLambdaParameters=ERR_ConvertVarLambdaParameters
28 changes: 21 additions & 7 deletions java.hints/test/unit/src/org/netbeans/modules/java/hints/suggestions/LambdaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,15 +552,14 @@ public void testExplicitParameterTypes() throws Exception {
"}\n");
}

//Todo: Verification is pending on nb-javac of JDK11
@Test
public void testImplicitVarParameterTypes1() throws Exception {
HintTest.create()
.setCaretMarker('^')
.input("package test;\n" +
"import java.util.function.IntBinaryOperator;\n" +
"public class Test {\n" +
" public void main(String list) {\n" +
" public void main(String[] args) {\n" +
" IntBinaryOperator calc3 = (int x, int y)^ -> x + y;\n" +
" }\n" +
"}\n")
Expand All @@ -572,38 +571,53 @@ public void testImplicitVarParameterTypes1() throws Exception {
.assertVerbatimOutput("package test;\n" +
"import java.util.function.IntBinaryOperator;\n" +
"public class Test {\n" +
" public void main(List<String> list) {\n" +
" public void main(String[] args) {\n" +
" IntBinaryOperator calc3 = (var x, var y) -> x + y;\n" +
" }\n" +
"}\n");
}

//Todo: Verification is pending on nb-javac of JDK11
@Test
public void testImplicitVarParameterTypes2() throws Exception {
HintTest.create()
.setCaretMarker('^')
.input("package test;\n" +
"import java.util.function.IntBinaryOperator;\n" +
"public class Test {\n" +
" public void main(String list) {\n" +
" public void main(String[] args) {\n" +
" IntBinaryOperator calc3 = (x, y)^ -> x + y;\n" +
" }\n" +
"}\n")
.sourceLevel("1.11")
.run(Lambda.class)
.findWarning("4:48-4:48:verifier:ERR_ConvertVarLambdaParameters")
.findWarning("4:40-4:40:verifier:ERR_ConvertVarLambdaParameters")
.applyFix()
.assertCompilable()
.assertVerbatimOutput("package test;\n" +
"import java.util.function.IntBinaryOperator;\n" +
"public class Test {\n" +
" public void main(List<String> list) {\n" +
" public void main(String[] args) {\n" +
" IntBinaryOperator calc3 = (var x, var y) -> x + y;\n" +
" }\n" +
"}\n");
}

@Test
public void testImplicitVarParameterTypes3() throws Exception {
HintTest.create()
.setCaretMarker('^')
.input("package test;\n" +
"import java.util.function.IntBinaryOperator;\n" +
"public class Test {\n" +
" public void main(String[] args) {\n" +
" IntBinaryOperator calc3 = (var x, var y)^ -> x + y;\n" +
" }\n" +
"}\n")
.sourceLevel("1.11")
.run(Lambda.class)
.assertNotContainsWarnings("ERR_ConvertVarLambdaParameters");
}

static {
JavacParser.DISABLE_SOURCE_LEVEL_DOWNGRADE = true;
}
Expand Down