Skip to content

Conversation

makiam
Copy link
Contributor

@makiam makiam commented Sep 30, 2025

Update Add Language Description panel layout to be properly resizable.

closes #4992


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added LSP [ci] enable Language Server Protocol tests UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 30, 2025
@apache apache locked and limited conversation to collaborators Sep 30, 2025
@apache apache unlocked this conversation Sep 30, 2025
@mbien
Copy link
Member

mbien commented Sep 30, 2025

hi @makiam, the layout is working better now but there are some small adjustments needed. E.g the "..." buttons have a tiny alignment issue and the Label - TextField distance is a bit high. And a few more, but its easier done than to explain, so I made the changes locally already.

before:
image

after:
image

If you are ok with it I would simply add it to your commit and force push into your branch.

@makiam
Copy link
Contributor Author

makiam commented Sep 30, 2025

Ok for me. Thank You

@mbien mbien force-pushed the language-panel-update branch from 2678818 to 23cb3c6 Compare September 30, 2025 21:25
@mbien mbien added this to the NB28 milestone Sep 30, 2025
@mbien mbien force-pushed the language-panel-update branch from 23cb3c6 to 9e295c1 Compare September 30, 2025 21:57
(minor adjustments by mbien)

Co-authored-by: Michael Bien <mbien42@gmail.com>
Signed-off-by: Maksim Khramov <maxtemplaar@gmail.com>
@mbien mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Sep 30, 2025
@mbien mbien force-pushed the language-panel-update branch from 9e295c1 to 7868cef Compare September 30, 2025 22:06
@mbien
Copy link
Member

mbien commented Sep 30, 2025

Will merge once CI is green again. Thanks for the updates.

@mbien mbien merged commit 02b2c5b into apache:master Sep 30, 2025
30 checks passed
@makiam makiam deleted the language-panel-update branch October 1, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components inside of the "Add Language Description" dialog are not properly resizable
2 participants