testing/himem_test: Verify the creation of himem and read/write chara… #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssssenai
force-pushed
the
himem-cdev-test
branch
2 times, most recently
from
063e18c to
d235204
Compare
ssssenai
force-pushed
the
himem-cdev-test
branch
from
d235204 to
c534114
Compare
|
@ssssenai could you fix the build break? |
yamt
reviewed
Aug 14, 2024
| default "himem_test" | ||
| ---help--- | ||
| This is the name of the program that will be used when the NSH ELF | ||
| program is installed. |
There was a problem hiding this comment.
This is a generic description in Kconfig.
| # see the file kconfig-language.txt in the NuttX tools repository. | ||
| # | ||
|
|
||
| config TESTING_HIMEM_TEST |
There was a problem hiding this comment.
i guess this should somehow depends on esp32.
There was a problem hiding this comment.
The configuration option needs to be enabled: CONFIG_ESP32_SPIRAM_BANKSWITCH_ENABLE. And has been added dependency on.
ssssenai
force-pushed
the
himem-cdev-test
branch
from
c534114 to
e5a71cb
Compare
I apologize for the late response, as this account has not been logged in for a long time. |
…cter devices, read/write multi block character devices, etc.
ssssenai
force-pushed
the
himem-cdev-test
branch
from
e5a71cb to
ec887c9
Compare
xiaoxiang781216
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Only esp32.
The configuration option needs to be enabled: CONFIG_ESP32_SPIRAM_BANKSWITCH_ENABLE.
Testing
Use esp32 & esp32-devkitc/psram.