Skip to content

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Feb 23, 2023

Summary

Remove CONFIG_EOL_IS_XXX relative logic since serial driver will do the convertion.

Please ignore nxstyle error from bas_fs.c.

Impact

Should be none.

Testing

cle/vi/bas/readline

@xiaoxiang781216
Copy link
Contributor

let's fix the style warning execpt "Mixer case"
https://github.com/apache/nuttx-apps/actions/runs/4249463510/jobs/7389640450

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@no1wudi
Copy link
Contributor Author

no1wudi commented Feb 23, 2023

let's fix the style warning execpt "Mixer case" https://github.com/apache/nuttx-apps/actions/runs/4249463510/jobs/7389640450

Fixed, and there also have error: Multiple data definitions from its origin code.

@xiaoxiang781216
Copy link
Contributor

let's fix the style warning execpt "Mixer case" https://github.com/apache/nuttx-apps/actions/runs/4249463510/jobs/7389640450

Fixed, and there also have error: Multiple data definitions from its origin code.

This need be fixed too.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@no1wudi
Copy link
Contributor Author

no1wudi commented Feb 23, 2023

This need be fixed too.

Done

@xiaoxiang781216 xiaoxiang781216 merged commit 7f67ee8 into apache:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants